Skip to content

Commit

Permalink
feat: add RDB_OPCODE_SLOT_INFO support for Redis 7.4 (#881)
Browse files Browse the repository at this point in the history
  • Loading branch information
suxb201 authored Nov 22, 2024
1 parent 6086d1d commit 7b2fd6f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ RedisShake is a powerful tool for Redis data transformation and migration, offer

1. **Zero Downtime Migration**: Enables seamless data migration without data loss or service interruption, ensuring continuous operation during the transfer process.

2. **Redis Compatibility**: Supports Redis 2.8 to 7.2, across standalone, master-slave, sentinel, and cluster deployments.
2. **Redis Compatibility**: Supports Redis 2.8 to 7.4, across standalone, master-slave, sentinel, and cluster deployments.

3. **Cloud Service Integration**: Seamlessly works with Redis-like databases from major cloud providers:
- Alibaba Cloud: [ApsaraDB for Redis](https://www.alibabacloud.com/product/apsaradb-for-redis), [Tair](https://www.alibabacloud.com/product/tair)
Expand Down
11 changes: 9 additions & 2 deletions internal/rdb/rdb.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ import (
)

const (
kFlagFunction2 = 245 // function library data
kFlagFunction = 246 // old function library data for 7.0 rc1 and rc2
kFlagSlotInfo = 244 // (Redis 7.4) RDB_OPCODE_SLOT_INFO: slot info
kFlagFunction2 = 245 // RDB_OPCODE_FUNCTION2: function library data
kFlagFunction = 246 // RDB_OPCODE_FUNCTION_PRE_GA: old function library data for 7.0 rc1 and rc2
kFlagModuleAux = 247 // RDB_OPCODE_MODULE_AUX: Module auxiliary data.
kFlagIdle = 248 // RDB_OPCODE_IDLE: LRU idle time.
kFlagFreq = 249 // RDB_OPCODE_FREQ: LFU frequency.
Expand Down Expand Up @@ -124,6 +125,12 @@ func (ld *Loader) parseRDBEntry(ctx context.Context, rd *bufio.Reader) {
typeByte := structure.ReadByte(rd)
log.Debugf("RDB type byte is: [%d]", typeByte)
switch typeByte {
case kFlagSlotInfo:
_ = structure.ReadLength(rd) // slot_id
_ = structure.ReadLength(rd) // slot_size
_ = structure.ReadLength(rd) // expires_slot_size
case kFlagFunction, kFlagFunction2:
log.Panicf("function library data not supported, need PR to support")
case kFlagModuleAux:
moduleId := structure.ReadLength(rd) // module id
moduleName := types.ModuleTypeNameByID(moduleId)
Expand Down

0 comments on commit 7b2fd6f

Please sign in to comment.