Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT-1237] Add Checkbox Component to Storybook #1253

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[FEAT-1237] Add Checkbox Component to Storybook #1253

wants to merge 3 commits into from

Conversation

umrkhn
Copy link
Contributor

@umrkhn umrkhn commented Nov 30, 2023

Fixes: #1237

Changes Made

  • Add stories for Checkbox component.
  • Align styles to match the Figma design

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

@umrkhn
Copy link
Contributor Author

umrkhn commented Dec 1, 2023

preview

Currently the "indeterminate" state doesn't exist do we need to include it as well ?

@Traxmaxx
Copy link
Contributor

Traxmaxx commented Dec 1, 2023

preview

Currently the "indeterminate" state doesn't exist do we need to include it as well ?

Hei!
If it's not too much work sure, why not. We can also create a separate issue for adding that if you prefer that.

@umrkhn
Copy link
Contributor Author

umrkhn commented Dec 1, 2023

preview
Currently the "indeterminate" state doesn't exist do we need to include it as well ?

Hei! If it's not too much work sure, why not. We can also create a separate issue for adding that if you prefer that.

I have a solution ready just need to fix some styling issues will push it soon.

@umrkhn umrkhn marked this pull request as draft December 3, 2023 17:18
@jakepage91
Copy link
Contributor

Hey there @umrkhn any updates here? Thanks!

@umrkhn
Copy link
Contributor Author

umrkhn commented Dec 19, 2023

@jakepage91 Sorry I couldn't work on it wasn't feeling well, and yeah I'll hopefully finish it within this week as I have a boat load of issues to work on.

@jakepage91
Copy link
Contributor

Sounds good @umrkhn ! Thanks for the update

@mlabouardy
Copy link
Collaborator

@jakepage91 Sorry I couldn't work on it wasn't feeling well, and yeah I'll hopefully finish it within this week as I have a boat load of issues to work on.

were you able to work on it?

@umrkhn umrkhn marked this pull request as ready for review January 23, 2024 09:56
@umrkhn umrkhn requested a review from Azanul as a code owner January 23, 2024 09:56
@umrkhn
Copy link
Contributor Author

umrkhn commented Jan 23, 2024

The indeterminate state doesn't seem to work quite well with the current implementation so I'm going to leave it as is, sorry for the delays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy Awaiting requested review from mlabouardy mlabouardy is a code owner

@ShubhamPalriwala ShubhamPalriwala Awaiting requested review from ShubhamPalriwala

@AvineshTripathi AvineshTripathi Awaiting requested review from AvineshTripathi AvineshTripathi is a code owner

@greghub greghub Awaiting requested review from greghub

@Traxmaxx Traxmaxx Awaiting requested review from Traxmaxx

@Azanul Azanul Awaiting requested review from Azanul Azanul is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add checkbox to Storybook
4 participants
@umrkhn @Traxmaxx @jakepage91 @mlabouardy