-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dropdown to Storybook #1235
Comments
Hey, i would like to work on this enhancement. |
All yours @AmalRichwin |
Hey @AmalRichwin, let me know your email so I can invite you to the Design System on Figma |
Hey @AllieMendes, I have pinged you my email in discord. |
Perfect, I've sent an invitation |
I have some questions is select and dropdown are same, if so there is already storybook component for select should i want to extend its behaviour. |
I'll record a video to explain the differences and behavior and send it to you through Figma, if that's alright @AmalRichwin |
Or we can jump on a call on Discord, if you're available |
Thank you @AllieMendes for the call and for taking the time to walk me through the differences between the dropdown and select components. Your explanation was incredibly helpful, and I now have a clear understanding of the distinctions. I've noticed that the current implementation of the dropdown component is hard-coded on specific screens/pages. I'm proposing a shift towards a more reusable approach by creating a standalone dropdown component, can i do that. |
Hei @AmalRichwin Sounds like a great idea! Feel free to adjust existing components as you need to in order to make them more reusable! |
You're very welcome @AmalRichwin, thank you for taking the time |
Currently the Dropbown component is missing in Storybook. Please add it to storybook so this component is properly documented.
https://www.figma.com/file/eq3JgvmW48IVrYcg2kzgLL/Komiser---Design-System?type=design&node-id=2039-15439&mode=dev
You will find a short intro into our Storybook setup in the Dashboard README
The text was updated successfully, but these errors were encountered: