Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dropdown to Storybook #1235

Open
Traxmaxx opened this issue Nov 27, 2023 · 11 comments
Open

Add Dropdown to Storybook #1235

Traxmaxx opened this issue Nov 27, 2023 · 11 comments

Comments

@Traxmaxx
Copy link
Contributor

Traxmaxx commented Nov 27, 2023

Currently the Dropbown component is missing in Storybook. Please add it to storybook so this component is properly documented.

Screenshot 2023-11-27 at 12 53 05

https://www.figma.com/file/eq3JgvmW48IVrYcg2kzgLL/Komiser---Design-System?type=design&node-id=2039-15439&mode=dev

You will find a short intro into our Storybook setup in the Dashboard README

@AmalRichwin
Copy link
Contributor

Hey, i would like to work on this enhancement.

@jakepage91
Copy link
Contributor

All yours @AmalRichwin

@AllieMendes
Copy link

Hey @AmalRichwin, let me know your email so I can invite you to the Design System on Figma

@AmalRichwin
Copy link
Contributor

Hey @AllieMendes, I have pinged you my email in discord.

@AllieMendes
Copy link

Perfect, I've sent an invitation
Don't hesitate to drop a comment if something is not clear/if you think the component can be improved to match Tailwind

@AmalRichwin
Copy link
Contributor

I have some questions is select and dropdown are same, if so there is already storybook component for select should i want to extend its behaviour.

@AllieMendes
Copy link

I'll record a video to explain the differences and behavior and send it to you through Figma, if that's alright @AmalRichwin

@AllieMendes
Copy link

Or we can jump on a call on Discord, if you're available

@AmalRichwin
Copy link
Contributor

Thank you @AllieMendes for the call and for taking the time to walk me through the differences between the dropdown and select components. Your explanation was incredibly helpful, and I now have a clear understanding of the distinctions.

I've noticed that the current implementation of the dropdown component is hard-coded on specific screens/pages. I'm proposing a shift towards a more reusable approach by creating a standalone dropdown component, can i do that.

@Traxmaxx
Copy link
Contributor Author

Traxmaxx commented Dec 1, 2023

Hei @AmalRichwin

Sounds like a great idea! Feel free to adjust existing components as you need to in order to make them more reusable!

@AllieMendes
Copy link

You're very welcome @AmalRichwin, thank you for taking the time
Absolutely, the goal of these tasks is to clear up hardcoded components and ease how we implement them, thank you for proposing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants