tailscale: allow configuring user data source using login_name or dis… #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
force-pushed
the
percy/users-by-name
branch
from
9748e79
to
ce95a56
Compare
mpminardi
reviewed
Sep 6, 2024
tailscale/data_source_user.go
Outdated
| Type: schema.TypeString, | ||
| Description: "The emailish login name of the user.", | ||
| Optional: true, | ||
| AtLeastOneOf: []string{"display_name", "login_name"}, |
There was a problem hiding this comment.
Should this be ExactlyOneOf instead of AtLeastOneOf, or are their cases where you would want to be specifying both and only specifying one wouldn't be enough to identify a single user?
There was a problem hiding this comment.
Per discussion, I'm only allowing use of login_name now.
oxtoacart
force-pushed
the
percy/users-by-name
branch
from
ce95a56
to
c7335a6
Compare
mpminardi
reviewed
Sep 6, 2024
tailscale/data_source_user.go
Outdated
| Description: "The emailish login name of the user.", | ||
| Optional: true, | ||
| }, | ||
| "display_name": { |
There was a problem hiding this comment.
Think we'll want to remove this now that it is back in the commonUserSchema
mpminardi
reviewed
Sep 6, 2024
tailscale/data_source_user.go
Outdated
| "login_name": { | ||
| Type: schema.TypeString, | ||
| Description: "The emailish login name of the user.", | ||
| Optional: true, |
There was a problem hiding this comment.
Now that this is the only way to query a user:
Suggested change
| Optional: true, | |
| Required: true, |
There was a problem hiding this comment.
It occurred to me that I'm still allowing use of ID, so I've updated the schema to make this clear.
oxtoacart
force-pushed
the
percy/users-by-name
branch
from
c7335a6
to
5e0e287
Compare
This is useful because clients typically have no knowledge of user IDs. Updates tailscale/corp#21867 Signed-off-by: Percy Wegmann <[email protected]>
oxtoacart
force-pushed
the
percy/users-by-name
branch
from
5e0e287
to
85c25de
Compare
mpminardi
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…play_name
This is useful because clients typically have no knowledge of user IDs.
Updates tailscale/corp#21867