tailscale: use V2 client for acl data source #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
force-pushed
the
percy/ds-acl-client-v2
branch
from
d72e82a
to
d2be0ba
Compare
Updates tailscale/corp#21867 Signed-off-by: Percy Wegmann <[email protected]>
oxtoacart
force-pushed
the
percy/ds-acl-client-v2
branch
from
d2be0ba
to
eccba91
Compare
tomhjp
approved these changes
Aug 23, 2024
tailscale/data_source_acl_test.go
Outdated
|
|
||
| rs := s.RootModule().Resources[resourceName].Primary | ||
| actual := rs.Attributes["hujson"] | ||
| if diff := cmp.Diff(expected, actual); diff != "" { |
There was a problem hiding this comment.
nit: I think these might be the wrong way round? ref
Suggested change
| if diff := cmp.Diff(expected, actual); diff != "" { | |
| if diff := cmp.Diff(actual, expected); diff != "" { |
There was a problem hiding this comment.
Ha, looks like we have a lot of these. I miss using stretchr/testify 😭
Updates tailscale/corp#21867 Signed-off-by: Percy Wegmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tailscale/corp#21867