-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari turns my go/link URL into a web search #9
Comments
Chrome does that as well sometimes, but it seems to "learn" that "go" is a valid hostname after a few successful resolutions. That doesn't seem to be working with Safari :( However, including a trailing slash does seem to work in Safari... does go/gmail/ work for you? |
The trailing / does help! All of the simple mappings I set up seem to work. The more complicated ones are, of course, more complicated. From go/.help this query for Google:
if I hit go/search/foo it never hits the golink rewriter, and if I hit go/search/foo/ it properly routes through golink but searches for "foo/" instead of "foo". (is there a way to truncate the last character of a string in the template language if that last character is a / ?) |
not currently. I suppose we could expose strings.TrimSuffix, so then you could have something like:
That's kind of annoying to have to add that to all of your links, though. I wonder if there's a better way that we could handle it automatically 🤔 |
okay, I can't figure out how to reliably reproduce it, but I now have Safari properly resolving |
I closed and reopened Safari, no bueno. But I do have an operating system upgrade to do to get to macOS 13.0.1 from 12.6, so if there's a change to be done that helps with that it's in my future. PR #10 adds in the TrimSuffix function, so that your example code above works. Agreed that there's certainly some better way to do it, but this gives me at least a working way forward. |
This might be solved by #21 |
Hello |
After adding the trailing slash (eg |
Updates #9 On tailnets with TLS enabled serve HTTP traffic with a separate redirectHandler which sends requests to our HTTPS listener destination. Add `-L` to documented examples of using `curl` to follow these redirects if present. Signed-off-by: Patrick O'Doherty <[email protected]>
golink: listen on HTTPS and redirect HTTP traffic Updates #9 Fixes #29 On tailnets with HTTPS enabled golink will serve the primary endpoints via HTTPS. With HTTPS enabled golink will respond to HTTP traffic with a separate redirectHandler which redirects requests to their HTTPS equivalent. Update documented examples of `curl` to include the `-L` flog to follow these redirects if present. Add a HTTPS section to the README documenting all of the above. Signed-off-by: Patrick O'Doherty <[email protected]>
System configuration: Safari Version 16.0 (17614.1.25.9.10, 17614), macOS Monterey 12.6 (21G115).
I have set up a "go" endpoint, and when I type "go" into the search / URL entry box, it properly sends me to the "go" endpoint on my talent.
I have a link defined, go/gmail . It's listed as a "popular link", and when I click on it it does the expected thing and redirects.
However.
If I type go/gmail into the URL entry box at the top, the system misinterprets go/gmail as a search string, and puts me on a Google search results page.
The issue appears to be "Safari ignores local domain" - https://discussions.apple.com/thread/5504425 - and the suggested workaround (ick) is to either use a fully qualified domain name, or use the http:// prefix. (Or, probably, use Chrome.)
The text was updated successfully, but these errors were encountered: