Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tailscale default version to 1.66.4 #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evenh
Copy link

@evenh evenh commented Oct 26, 2023

I noticed that the default version was out of date, hence this PR.

@evenh evenh changed the title Update Tailscale default version to 1.50.1 Update Tailscale default version to 1.54.0 Nov 20, 2023
@venkatamutyala
Copy link

It's 1.66.4 now.

@jayvdb
Copy link
Contributor

jayvdb commented Jun 8, 2024

Hi @evenh , could you update this to use the latest

@evenh evenh changed the title Update Tailscale default version to 1.54.0 Update Tailscale default version to 1.66.4 Jun 8, 2024
@evenh
Copy link
Author

evenh commented Jun 8, 2024

Bumped!

@Zebradil
Copy link

Zebradil commented Jun 9, 2024

Does it make sense to configure Renovate to update the version automatically?

@evenh
Copy link
Author

evenh commented Jun 9, 2024

I would love that but it is up to the maintainers to decide. I hope they say yes in order to ensure that consumers are up to date.

See #28 (comment)

@Zebradil
Copy link

I would love that but it is up to the maintainers to decide. I hope they say yes in order to ensure that consumers are up to date.

See #28 (comment)

I haven't seen the comment you linked before, it seems reasonable to me.

The workaround is quite simple. In our workflows we currently use the following step to connect to the tailnet:

jobs:
  some-job:
    steps:
      - name: 'Tailscale'
        uses: 'tailscale/github-action@4e4c49acaa9818630ce0bd7a564372c17e33fb4d' # v2.0.0
        env:
          # See https://docs.renovatebot.com/presets-customManagers/#custommanagersgithubactionsversions
          # renovate: datasource=github-releases depName=tailscale/tailscale
          TAILSCALE_VERSION: '1.66.4'
        with:
          authkey: '${{ secrets.TAILSCALE_AUTHKEY }}'
          version: '${{ env.TAILSCALE_VERSION }}'

With the following bit in the renovate config:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["regexManagers:githubActionsVersions"]
}

The TAILSCALE_VERSION is only needed to use the built-in regexManagers:githubActionsVersions preset. If it is not desirable, one can define their own rule using the Regex Manager to update version in-place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants