Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge "success", "failure", "warning" and "bold" functions #3

Open
tadeck opened this issue Dec 27, 2011 · 0 comments
Open

Merge "success", "failure", "warning" and "bold" functions #3

tadeck opened this issue Dec 27, 2011 · 0 comments
Milestone
Initial code cleanup

Comments

@tadeck
Copy link
Owner

tadeck commented Dec 27, 2011

Currently success, failure, warning and bold do almost exactly the same thing, without applying DRY rule. They should use common code part, allowing for flexibility in future feature creation.

Create additional method, eg. _formatted_message(msg, color=1, bold=False), to support code reuse.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Initial code cleanup
Development

No branches or pull requests
1 participant
@tadeck