-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config file vs source code file for presets #158
Comments
While I do WANT to drive adoption of my project, I had the same thought after reading that issue. I'm ok with a few core projects staying in (CRA, styled-components, apollo, et al), we definitely have to draw a line eventually, and can only do this once we have an alternative route. I can see even core projects wanting their config inline I agree a file is a good place to do this. Passing that number of configs inline, while possible is not a terribly good idea. Considerations for the design of this feature:
Feel free to open a PR! |
please add this. That would make this project able to support usage in any other lib/project in general. Not just for the handful few projects in that have their key in |
To be fair, I don't think we actually need presets or config files. We (Material-UI) are just publishing our own package ( That should be sufficient and is even shorter: -npx envinfo --preset material-ui
+npx @material-ui/envinfo |
Looking at PR #153 made me wonder where the line should be drawn for adding presets.
Would it make more sense to have a file like .envinfo that we could read from to figure out a project’s configuration instead of requiring PRs to the presets file?
I’d be happy to work on a pr adding that if others agree it’d be a good approach to take.
The text was updated successfully, but these errors were encountered: