fmtr-text: do not round up time #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code rounds (up) milliseconds when dividing the system-provided microsecond time. Furthermore, if the result of the rounding exceeds 1000ms, it increments the system-provided seconds. This is wrong as it effectively "pushes time forward", reporting a future time that is not passed at the time of the timestamp collection. Time should never be rounded, time scale divisions should always be truncated to keep past, present and future in the right order. This patch fixes this by removing the incorrect time adjustment. tv_usec is guaranteed to always be in the range [0, 999,999]. This also uses integer-based computation instead of (expensive) FP64.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code rounds (up) milliseconds when dividing the system-provided microsecond time. Furthermore, if the result of the rounding exceeds 1000ms, it increments the system-provided seconds.
This is wrong as it effectively "pushes time forward", reporting a future time that is not passed at the time of the timestamp collection.
Time should never be rounded, time scale divisions should always be truncated to keep past, present and future in the right order.
This patch fixes this by removing the incorrect time adjustment. tv_usec is guaranteed to always be in the range [0, 999,999]. This also uses integer-based computation instead of (expensive) FP64.