Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Ability to write GainMap #36

Open
eszdman opened this issue Oct 19, 2023 · 8 comments
Open

[TODO] Ability to write GainMap #36

eszdman opened this issue Oct 19, 2023 · 8 comments

Comments

@eszdman
Copy link

eszdman commented Oct 19, 2023

Please, provide ability to write GainMap into dng file.
This is a necessary thing when creating a dng file with camera lens shading.

@syoyo
Copy link
Owner

syoyo commented Oct 20, 2023

You can contribute or you can sponsor prioritizing implement GainMap write feature

@electro-logic
Copy link

You can use a simpler opcode called "FixVignetteRadial" to correct the camera shading. Have a look at my project DngOpcodesEditor to try out that opcode.

@syoyo
Copy link
Owner

syoyo commented Oct 26, 2023

Interesting! > DngOpcodesEditor.

BTW, I think usually many cameras(includes Android's DNG support) only provide GainMap opcode.

@electro-logic
Copy link

Hello @syoyo,
Not all opcodes are extensively used. I have seen many smartphones using FixVignetteRadial, some drones use WarpRectilinear and GainMap. I'm now trying to implement GainMap because is pretty popular, keep watching the project.

@syoyo
Copy link
Owner

syoyo commented Oct 27, 2023

Thanks! Good to know! > I have seen many smartphones using FixVignetteRadial, some drones use WarpRectilinear and GainMap

@electro-logic
Copy link

You can already find a working implementation of the opcode in the repository. Some border cases are not handled yet, but seems working.

@eszdman
Copy link
Author

eszdman commented Nov 2, 2023

Hello @syoyo, Not all opcodes are extensively used. I have seen many smartphones using FixVignetteRadial, some drones use WarpRectilinear and GainMap. I'm now trying to implement GainMap because is pretty popular, keep watching the project.

It would be nice if you wrote an algorithm that can convert gainmaps back and forth with this opcode

@electro-logic
Copy link

@syoyo Do you have an use case for this scenario? The conversion FixVignetteRadial->GainMap is feasible, but you can have only have an approximation from GainMap to FixVignetteRadial. For example DJI uses the GainMap to fix vignetting, correct aberration and balance a bit colors at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants