New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[application.erl] redundant case statement #2

Open

tank-bohr opened this issue Jul 19, 2019 · 1 comment

Collaborator

tank-bohr commented Jul 19, 2019

https://github.com/erlang/otp/blob/34b56e8f566c6f1aa6023bb7b4096b8f2d709d9e/lib/kernel/src/application.erl#L229-L233

Should be moved to function guard

permit(_Application, Bool) when !is_boolean(Bool)
    exit({badarg, {?MODULE, permit, [Application, Bad]}});
permit(Application, Bool)
   ...

And we can do even better

permit(_Application, Bool) when is_boolean(Bool)
    ...

Member

5HT commented Jul 19, 2019

Here we need to rewrite entire dist_ac module with our own QUIC based distribution protocol!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment