From 80138f98859b28ba3a2b0f8e961c461cfeda461a Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Tue, 22 Aug 2023 09:10:24 +0200
Subject: [PATCH] Remove CheckAttributteArgumentClassExistsRule as should be
 handled by PHPStan

---
 config/static-rules.neon                      |   1 -
 docs/rules_overview.md                        |  30 +----
 ...CheckAttributteArgumentClassExistsRule.php | 107 ------------------
 ...kAttributteArgumentClassExistsRuleTest.php |  45 --------
 .../SkipExistingClassAttributeArgument.php    |  13 ---
 ...ClassWithAttributeArgumentMissingClass.php |  13 ---
 .../Source/ExistingClass.php                  |  10 --
 .../Source/SomeAttribute.php                  |  15 ---
 .../config/configured_rule.neon               |   5 -
 9 files changed, 1 insertion(+), 238 deletions(-)
 delete mode 100644 src/Rules/CheckAttributteArgumentClassExistsRule.php
 delete mode 100644 tests/Rules/CheckAttributteArgumentClassExistsRule/CheckAttributteArgumentClassExistsRuleTest.php
 delete mode 100644 tests/Rules/CheckAttributteArgumentClassExistsRule/Fixture/SkipExistingClassAttributeArgument.php
 delete mode 100644 tests/Rules/CheckAttributteArgumentClassExistsRule/Fixture/SomeClassWithAttributeArgumentMissingClass.php
 delete mode 100644 tests/Rules/CheckAttributteArgumentClassExistsRule/Source/ExistingClass.php
 delete mode 100644 tests/Rules/CheckAttributteArgumentClassExistsRule/Source/SomeAttribute.php
 delete mode 100644 tests/Rules/CheckAttributteArgumentClassExistsRule/config/configured_rule.neon

diff --git a/config/static-rules.neon b/config/static-rules.neon
index fa56ef94..91e1e862 100644
--- a/config/static-rules.neon
+++ b/config/static-rules.neon
@@ -8,7 +8,6 @@ rules:
     # domain
     - Symplify\PHPStanRules\Rules\Domain\RequireExceptionNamespaceRule
     - Symplify\PHPStanRules\Rules\Domain\RequireAttributeNamespaceRule
-    - Symplify\PHPStanRules\Rules\CheckAttributteArgumentClassExistsRule
     - Symplify\PHPStanRules\Rules\Enum\RequireUniqueEnumConstantRule
     - Symplify\PHPStanRules\Rules\ForbiddenParamTypeRemovalRule
     - Symplify\PHPStanRules\Rules\PreventParentMethodVisibilityOverrideRule
diff --git a/docs/rules_overview.md b/docs/rules_overview.md
index dc52ec54..5ba65570 100644
--- a/docs/rules_overview.md
+++ b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 67 Rules Overview
+# 66 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -65,34 +65,6 @@ class SomeClass
 
 <br>
 
-## CheckAttributteArgumentClassExistsRule
-
-Class was not found
-
-- class: [`Symplify\PHPStanRules\Rules\CheckAttributteArgumentClassExistsRule`](../src/Rules/CheckAttributteArgumentClassExistsRule.php)
-
-```php
-#[SomeAttribute(firstName: 'MissingClass::class')]
-class SomeClass
-{
-}
-```
-
-:x:
-
-<br>
-
-```php
-#[SomeAttribute(firstName: ExistingClass::class)]
-class SomeClass
-{
-}
-```
-
-:+1:
-
-<br>
-
 ## CheckClassNamespaceFollowPsr4Rule
 
 Class like namespace "%s" does not follow PSR-4 configuration in `composer.json`
diff --git a/src/Rules/CheckAttributteArgumentClassExistsRule.php b/src/Rules/CheckAttributteArgumentClassExistsRule.php
deleted file mode 100644
index 026db055..00000000
--- a/src/Rules/CheckAttributteArgumentClassExistsRule.php
+++ /dev/null
@@ -1,107 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Symplify\PHPStanRules\Rules;
-
-use PhpParser\Node;
-use PhpParser\Node\AttributeGroup;
-use PhpParser\Node\Expr;
-use PhpParser\Node\Expr\ClassConstFetch;
-use PhpParser\Node\Identifier;
-use PHPStan\Analyser\Scope;
-use PHPStan\Reflection\ReflectionProvider;
-use PHPStan\Rules\Rule;
-use PHPStan\Type\Constant\ConstantStringType;
-use Symplify\RuleDocGenerator\Contract\DocumentedRuleInterface;
-use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
-use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
-
-/**
- * @see \Symplify\PHPStanRules\Tests\Rules\CheckAttributteArgumentClassExistsRule\CheckAttributteArgumentClassExistsRuleTest
- *
- * @implements Rule<AttributeGroup>
- */
-final class CheckAttributteArgumentClassExistsRule implements Rule, DocumentedRuleInterface
-{
-    /**
-     * @var string
-     */
-    public const ERROR_MESSAGE = 'Class was not found';
-
-    public function __construct(
-        private readonly ReflectionProvider $reflectionProvider,
-    ) {
-    }
-
-    public function getNodeType(): string
-    {
-        return AttributeGroup::class;
-    }
-
-    /**
-     * @param AttributeGroup $node
-     * @return string[]
-     */
-    public function processNode(Node $node, Scope $scope): array
-    {
-        $ruleErrors = [];
-
-        foreach ($node->attrs as $attribute) {
-            foreach ($attribute->args as $arg) {
-                $value = $arg->value;
-                if (! $this->isClassConstFetch($value)) {
-                    continue;
-                }
-
-                $valueType = $scope->getType($value);
-                if (! $valueType instanceof ConstantStringType) {
-                    $ruleErrors[] = self::ERROR_MESSAGE;
-                    continue;
-                }
-
-                if ($this->reflectionProvider->hasClass($valueType->getValue())) {
-                    continue;
-                }
-
-                $ruleErrors[] = self::ERROR_MESSAGE;
-            }
-        }
-
-        return $ruleErrors;
-    }
-
-    public function getRuleDefinition(): RuleDefinition
-    {
-        return new RuleDefinition(self::ERROR_MESSAGE, [
-            new CodeSample(
-                <<<'CODE_SAMPLE'
-#[SomeAttribute(firstName: 'MissingClass::class')]
-class SomeClass
-{
-}
-CODE_SAMPLE
-                ,
-                <<<'CODE_SAMPLE'
-#[SomeAttribute(firstName: ExistingClass::class)]
-class SomeClass
-{
-}
-CODE_SAMPLE
-            ),
-        ]);
-    }
-
-    private function isClassConstFetch(Expr $expr): bool
-    {
-        if (! $expr instanceof ClassConstFetch) {
-            return false;
-        }
-
-        if (! $expr->name instanceof Identifier) {
-            return false;
-        }
-
-        return $expr->name->toString() === 'class';
-    }
-}
diff --git a/tests/Rules/CheckAttributteArgumentClassExistsRule/CheckAttributteArgumentClassExistsRuleTest.php b/tests/Rules/CheckAttributteArgumentClassExistsRule/CheckAttributteArgumentClassExistsRuleTest.php
deleted file mode 100644
index 392169a9..00000000
--- a/tests/Rules/CheckAttributteArgumentClassExistsRule/CheckAttributteArgumentClassExistsRuleTest.php
+++ /dev/null
@@ -1,45 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Symplify\PHPStanRules\Tests\Rules\CheckAttributteArgumentClassExistsRule;
-
-use Iterator;
-use PHPStan\Rules\Rule;
-use PHPStan\Testing\RuleTestCase;
-use PHPUnit\Framework\Attributes\DataProvider;
-use Symplify\PHPStanRules\Rules\CheckAttributteArgumentClassExistsRule;
-
-final class CheckAttributteArgumentClassExistsRuleTest extends RuleTestCase
-{
-    /**
-     * @param mixed[] $expectedErrorsWithLines
-     */
-    #[DataProvider('provideData')]
-    public function testRule(string $filePath, array $expectedErrorsWithLines): void
-    {
-        $this->analyse([$filePath], $expectedErrorsWithLines);
-    }
-
-    public static function provideData(): Iterator
-    {
-        yield [__DIR__ . '/Fixture/SkipExistingClassAttributeArgument.php', []];
-
-        yield [__DIR__ . '/Fixture/SomeClassWithAttributeArgumentMissingClass.php', [
-            [CheckAttributteArgumentClassExistsRule::ERROR_MESSAGE, 9],
-        ]];
-    }
-
-    /**
-     * @return string[]
-     */
-    public static function getAdditionalConfigFiles(): array
-    {
-        return [__DIR__ . '/config/configured_rule.neon'];
-    }
-
-    protected function getRule(): Rule
-    {
-        return self::getContainer()->getByType(CheckAttributteArgumentClassExistsRule::class);
-    }
-}
diff --git a/tests/Rules/CheckAttributteArgumentClassExistsRule/Fixture/SkipExistingClassAttributeArgument.php b/tests/Rules/CheckAttributteArgumentClassExistsRule/Fixture/SkipExistingClassAttributeArgument.php
deleted file mode 100644
index ee497f33..00000000
--- a/tests/Rules/CheckAttributteArgumentClassExistsRule/Fixture/SkipExistingClassAttributeArgument.php
+++ /dev/null
@@ -1,13 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Symplify\PHPStanRules\Tests\Rules\CheckAttributteArgumentClassExistsRule\Fixture;
-
-use Symplify\PHPStanRules\Tests\Rules\CheckAttributteArgumentClassExistsRule\Source\ExistingClass;
-use Symplify\PHPStanRules\Tests\Rules\CheckAttributteArgumentClassExistsRule\Source\SomeAttribute;
-
-#[SomeAttribute(className: ExistingClass::class)]
-final class SkipExistingClassAttributeArgument
-{
-}
diff --git a/tests/Rules/CheckAttributteArgumentClassExistsRule/Fixture/SomeClassWithAttributeArgumentMissingClass.php b/tests/Rules/CheckAttributteArgumentClassExistsRule/Fixture/SomeClassWithAttributeArgumentMissingClass.php
deleted file mode 100644
index 0c8d2e58..00000000
--- a/tests/Rules/CheckAttributteArgumentClassExistsRule/Fixture/SomeClassWithAttributeArgumentMissingClass.php
+++ /dev/null
@@ -1,13 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Symplify\PHPStanRules\Tests\Rules\CheckAttributteArgumentClassExistsRule\Fixture;
-
-use Symplify\PHPStanRules\Tests\Rules\CheckAttributteArgumentClassExistsRule\Source\SomeAttribute;
-
-#[SomeAttribute(className: MissingClass::class)]
-final class SomeClassWithAttributeArgumentMissingClass
-{
-}
-
diff --git a/tests/Rules/CheckAttributteArgumentClassExistsRule/Source/ExistingClass.php b/tests/Rules/CheckAttributteArgumentClassExistsRule/Source/ExistingClass.php
deleted file mode 100644
index 45de7bc0..00000000
--- a/tests/Rules/CheckAttributteArgumentClassExistsRule/Source/ExistingClass.php
+++ /dev/null
@@ -1,10 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Symplify\PHPStanRules\Tests\Rules\CheckAttributteArgumentClassExistsRule\Source;
-
-final class ExistingClass
-{
-
-}
diff --git a/tests/Rules/CheckAttributteArgumentClassExistsRule/Source/SomeAttribute.php b/tests/Rules/CheckAttributteArgumentClassExistsRule/Source/SomeAttribute.php
deleted file mode 100644
index 69aad8be..00000000
--- a/tests/Rules/CheckAttributteArgumentClassExistsRule/Source/SomeAttribute.php
+++ /dev/null
@@ -1,15 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Symplify\PHPStanRules\Tests\Rules\CheckAttributteArgumentClassExistsRule\Source;
-
-use Attribute;
-
-#[Attribute]
-final class SomeAttribute
-{
-    public function __construct(string $className)
-    {
-    }
-}
diff --git a/tests/Rules/CheckAttributteArgumentClassExistsRule/config/configured_rule.neon b/tests/Rules/CheckAttributteArgumentClassExistsRule/config/configured_rule.neon
deleted file mode 100644
index 70536b1a..00000000
--- a/tests/Rules/CheckAttributteArgumentClassExistsRule/config/configured_rule.neon
+++ /dev/null
@@ -1,5 +0,0 @@
-includes:
-    - ../../../config/included_services.neon
-
-rules:
-    - Symplify\PHPStanRules\Rules\CheckAttributteArgumentClassExistsRule