Remove NoMixedCallableRule, as handled by PHPStan - https://phpstan.o…

…rg/writing-php-code/phpdoc-types\#callables
symplify · Aug 22, 2023 · 5360efd · 5360efd
1 parent 8e54ff5
commit 5360efd
Show file tree

Hide file tree

Showing 13 changed files with 0 additions and 288 deletions.
diff --git a/config/code-complexity-rules.neon b/config/code-complexity-rules.neon
@@ -1,5 +1,4 @@
 rules:
-    - Symplify\PHPStanRules\Rules\Explicit\NoMixedCallableRule
     - Symplify\PHPStanRules\Rules\Explicit\NoMixedPropertyFetcherRule
     - Symplify\PHPStanRules\Rules\Explicit\NoMixedMethodCallerRule
     - Symplify\PHPStanRules\Rules\Complexity\ForbiddenNamedArgumentsRule

diff --git a/phpstan.neon b/phpstan.neon
@@ -36,11 +36,6 @@ parameters:
         - '#Class Symplify\\PHPStanRules\\(.*?)Rule implements generic interface PHPStan\\Rules\\Rule but does not specify its types\: TNodeType#'
         - '#Method (.*?)::getCollectors\(\) return type with generic interface PHPStan\\Collectors\\Collector does not specify its types\: TNodeType, TValue#'
 
-        # invalid PHPStan type - it alwasy requires 2 types to traverse with callable
-        -
-            message: '#Callable callable\(PHPStan\\Type\\Type\)\: PHPStan\\Type\\Type invoked with 2 parameters, 1 required#'
-            path: src/Rules/Explicit/NoMixedCallableRule.php
-
         - '#Parameter \#1 \$values of method Symplify\\PHPStanRules\\Rules\\Enum\\RequireUniqueEnumConstantRule\:\:filterDuplicatedValues\(\) expects array<int\|string>, array<bool\|float\|int\|string> given#'
 
         - '#Class PHP_CodeSniffer\\Sniffs\\Sniff not found#'

diff --git a/src/Rules/Explicit/NoMixedCallableRule.php b/src/Rules/Explicit/NoMixedCallableRule.php
diff --git a/tests/Rules/Explicit/NoMixedCallableRule/Fixture/DocOnlyNullableReturnCallable.php b/tests/Rules/Explicit/NoMixedCallableRule/Fixture/DocOnlyNullableReturnCallable.php
diff --git a/tests/Rules/Explicit/NoMixedCallableRule/Fixture/MixedCallable.php b/tests/Rules/Explicit/NoMixedCallableRule/Fixture/MixedCallable.php
diff --git a/tests/Rules/Explicit/NoMixedCallableRule/Fixture/NullableMixedCallable.php b/tests/Rules/Explicit/NoMixedCallableRule/Fixture/NullableMixedCallable.php
diff --git a/tests/Rules/Explicit/NoMixedCallableRule/Fixture/NullableReturnCallable.php b/tests/Rules/Explicit/NoMixedCallableRule/Fixture/NullableReturnCallable.php
diff --git a/tests/Rules/Explicit/NoMixedCallableRule/Fixture/ReturnCallable.php b/tests/Rules/Explicit/NoMixedCallableRule/Fixture/ReturnCallable.php
diff --git a/tests/Rules/Explicit/NoMixedCallableRule/Fixture/SkipParamDefinedCallable.php b/tests/Rules/Explicit/NoMixedCallableRule/Fixture/SkipParamDefinedCallable.php
diff --git a/tests/Rules/Explicit/NoMixedCallableRule/Fixture/SkipReturnDefinedCallable.php b/tests/Rules/Explicit/NoMixedCallableRule/Fixture/SkipReturnDefinedCallable.php
diff --git a/tests/Rules/Explicit/NoMixedCallableRule/Fixture/UnionMixedCallable.php b/tests/Rules/Explicit/NoMixedCallableRule/Fixture/UnionMixedCallable.php
diff --git a/tests/Rules/Explicit/NoMixedCallableRule/NoMixedCallableRuleTest.php b/tests/Rules/Explicit/NoMixedCallableRule/NoMixedCallableRuleTest.php
diff --git a/tests/Rules/Explicit/NoMixedCallableRule/config/configured_rule.neon b/tests/Rules/Explicit/NoMixedCallableRule/config/configured_rule.neon