Skip to content

Commit

Permalink
Remove NoVoidGetterMethodRule as not that practical
Browse files Browse the repository at this point in the history
  • Loading branch information
TomasVotruba committed May 25, 2024
1 parent a9766b3 commit 11e74f2
Show file tree
Hide file tree
Showing 14 changed files with 1 addition and 365 deletions.
36 changes: 1 addition & 35 deletions docs/rules_overview.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# 41 Rules Overview
# 40 Rules Overview

## AnnotateRegexClassConstWithRegexLinkRule

Expand Down Expand Up @@ -1100,40 +1100,6 @@ final class SkipApiMock extends TestCase

<br>

## NoVoidGetterMethodRule

Getter method must return something, not void

- class: [`Symplify\PHPStanRules\Rules\NoVoidGetterMethodRule`](../src/Rules/NoVoidGetterMethodRule.php)

```php
final class SomeClass
{
public function getData(): void
{
// ...
}
}
```

:x:

<br>

```php
final class SomeClass
{
public function getData(): array
{
// ...
}
}
```

:+1:

<br>

## PreferredClassRule

Instead of "%s" class/interface use "%s"
Expand Down
142 changes: 0 additions & 142 deletions src/Rules/NoVoidGetterMethodRule.php

This file was deleted.

10 changes: 0 additions & 10 deletions tests/Rules/NoVoidGetterMethodRule/Fixture/SkipAbstractGetter.php

This file was deleted.

This file was deleted.

17 changes: 0 additions & 17 deletions tests/Rules/NoVoidGetterMethodRule/Fixture/SkipIfElseReturn.php

This file was deleted.

This file was deleted.

16 changes: 0 additions & 16 deletions tests/Rules/NoVoidGetterMethodRule/Fixture/SkipNoThrows.php

This file was deleted.

12 changes: 0 additions & 12 deletions tests/Rules/NoVoidGetterMethodRule/Fixture/SkipSetter.php

This file was deleted.

15 changes: 0 additions & 15 deletions tests/Rules/NoVoidGetterMethodRule/Fixture/SkipYieldFrom.php

This file was deleted.

15 changes: 0 additions & 15 deletions tests/Rules/NoVoidGetterMethodRule/Fixture/SkipYielder.php

This file was deleted.

12 changes: 0 additions & 12 deletions tests/Rules/NoVoidGetterMethodRule/Fixture/SomeGetterVoid.php

This file was deleted.

This file was deleted.

51 changes: 0 additions & 51 deletions tests/Rules/NoVoidGetterMethodRule/NoVoidGetterMethodRuleTest.php

This file was deleted.

This file was deleted.

0 comments on commit 11e74f2

Please sign in to comment.