Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status returns bad codes #78

Open
symkat opened this issue Apr 13, 2015 · 3 comments
Open

Status returns bad codes #78

symkat opened this issue Apr 13, 2015 · 3 comments

Comments

@symkat
Copy link
Owner

symkat commented Apr 13, 2015

$ sudo service httpd status
httpd is stopped
$ echo $?
3
$ sudo my_daemon status
my_daemon                                                    [Not Running]
$ echo $?
0

The exit cods for status should reflect the exit codes in the following documentation:

http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html

@dr-kd
Copy link

dr-kd commented Apr 13, 2015

looks like it's trying to do the right thing here but some star or other is out of alignment.

@symkat
Copy link
Owner Author

symkat commented Apr 13, 2015

So, it looks like it's been fixed here: https://github.com/jhard/Daemon-Control/commit/909a3424d72b4dac76797c0026c895f36ad5484a

And I've done the thing where I haven't shipped the changes to CPAN yet. Give me a few days, and I'll see about reviewing the other pull requests and cutting a new release.

@shadowcat-mst
Copy link
Contributor

Maybe worth having ->run_and_exit instead of ->run depending ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants