Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Fork Writes PID (#16 regression) #71

Open
mydimension opened this issue Dec 30, 2014 · 3 comments
Open

Single Fork Writes PID (#16 regression) #71

mydimension opened this issue Dec 30, 2014 · 3 comments

Comments

@mydimension
Copy link

Looks like #16 regressed. The current version (0.001006) writes a pid file in fork==1 mode when the documentation says it should not.

@zoffixznet
Copy link
Contributor

Found the commit f657f78 with explicit changelog message 'properly write the pid file in single fork mode' by @karenetheridge

Also, this bit of code has a comment "make sure pid file exists": https://github.com/symkat/Daemon-Control/blame/master/lib/Daemon/Control.pm#L463 The pid file is created even when fork is set to 0.

I could submit a PR if the correct behavior is pinned down. Let me know.

@mydimension
Copy link
Author

The current POD regarding pid_file and fork would seem to be the target behavior. That is fork<2 results in no pid_file being written, leaving it the responsibility of the program to write it's own pid_file and additionally have it be the file that D::C expects.

@mydimension
Copy link
Author

Any update/movement on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants