From 0228dd1180ee3ef6c85eeb51ddbe89e0eaef7d33 Mon Sep 17 00:00:00 2001
From: Markus Staab <maggus.staab@googlemail.com>
Date: Sun, 27 Oct 2024 07:46:44 +0100
Subject: [PATCH] Don't use `die()` in PHPT `--SKIPIF--`

Unlocks a performance optimization in PHPUnit 11.x

see https://staabm.github.io/2024/10/19/phpunit-codesprint-munich.html
---
 Tests/DeprecationErrorHandler/log_file.phpt | 2 +-
 Tests/expectdeprecationfail.phpt            | 2 +-
 Tests/expectnotrisky.phpt                   | 4 ++--
 Tests/expectrisky.phpt                      | 4 ++--
 Tests/symfonyextension.phpt                 | 2 +-
 Tests/symfonyextensionnotregistered.phpt    | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Tests/DeprecationErrorHandler/log_file.phpt b/Tests/DeprecationErrorHandler/log_file.phpt
index fe14db7..12f9ed4 100644
--- a/Tests/DeprecationErrorHandler/log_file.phpt
+++ b/Tests/DeprecationErrorHandler/log_file.phpt
@@ -1,7 +1,7 @@
 --TEST--
 Test DeprecationErrorHandler with log file
 --SKIPIF--
-<?php if (!getenv('SYMFONY_PHPUNIT_VERSION') || version_compare(getenv('SYMFONY_PHPUNIT_VERSION'), '10.0', '>=')) die('Skipping on PHPUnit 10+');
+<?php if (!getenv('SYMFONY_PHPUNIT_VERSION') || version_compare(getenv('SYMFONY_PHPUNIT_VERSION'), '10.0', '>=')) echo 'Skipping on PHPUnit 10+';
 --FILE--
 <?php
 $filename = tempnam(sys_get_temp_dir(), 'sf-');
diff --git a/Tests/expectdeprecationfail.phpt b/Tests/expectdeprecationfail.phpt
index 6181146..be30223 100644
--- a/Tests/expectdeprecationfail.phpt
+++ b/Tests/expectdeprecationfail.phpt
@@ -1,7 +1,7 @@
 --TEST--
 Test ExpectDeprecationTrait failing tests
 --SKIPIF--
-<?php if (!getenv('SYMFONY_PHPUNIT_VERSION') || version_compare(getenv('SYMFONY_PHPUNIT_VERSION'), '10.0', '>=')) die('Skipping on PHPUnit 10+');
+<?php if (!getenv('SYMFONY_PHPUNIT_VERSION') || version_compare(getenv('SYMFONY_PHPUNIT_VERSION'), '10.0', '>=')) echo 'Skipping on PHPUnit 10+';
 --FILE--
 <?php
 $test =  realpath(__DIR__.'/FailTests/ExpectDeprecationTraitTestFail.php');
diff --git a/Tests/expectnotrisky.phpt b/Tests/expectnotrisky.phpt
index 4fecb94..aae9802 100644
--- a/Tests/expectnotrisky.phpt
+++ b/Tests/expectnotrisky.phpt
@@ -2,8 +2,8 @@
 Test NoAssertionsTestNotRisky not risky test
 --SKIPIF--
 <?php
-if ('\\' === DIRECTORY_SEPARATOR && !extension_loaded('mbstring')) die('Skipping on Windows without mbstring');
-if (!getenv('SYMFONY_PHPUNIT_VERSION') || version_compare(getenv('SYMFONY_PHPUNIT_VERSION'), '10.0', '>=')) die('Skipping on PHPUnit 10+');
+if ('\\' === DIRECTORY_SEPARATOR && !extension_loaded('mbstring')) echo 'Skipping on Windows without mbstring';
+if (!getenv('SYMFONY_PHPUNIT_VERSION') || version_compare(getenv('SYMFONY_PHPUNIT_VERSION'), '10.0', '>=')) echo 'Skipping on PHPUnit 10+';
 --FILE--
 <?php
 $test =  realpath(__DIR__.'/FailTests/NoAssertionsTestNotRisky.php');
diff --git a/Tests/expectrisky.phpt b/Tests/expectrisky.phpt
index 2e8d493..6762255 100644
--- a/Tests/expectrisky.phpt
+++ b/Tests/expectrisky.phpt
@@ -2,8 +2,8 @@
 Test NoAssertionsTestRisky risky test
 --SKIPIF--
 <?php
-if ('\\' === DIRECTORY_SEPARATOR && !extension_loaded('mbstring')) die('Skipping on Windows without mbstring');
-if (!getenv('SYMFONY_PHPUNIT_VERSION') || version_compare(getenv('SYMFONY_PHPUNIT_VERSION'), '10.0', '>=')) die('Skipping on PHPUnit 10+');
+if ('\\' === DIRECTORY_SEPARATOR && !extension_loaded('mbstring')) echo 'Skipping on Windows without mbstring';
+if (!getenv('SYMFONY_PHPUNIT_VERSION') || version_compare(getenv('SYMFONY_PHPUNIT_VERSION'), '10.0', '>=')) echo 'Skipping on PHPUnit 10+';
 --FILE--
 <?php
 $test =  realpath(__DIR__.'/FailTests/NoAssertionsTestRisky.php');
diff --git a/Tests/symfonyextension.phpt b/Tests/symfonyextension.phpt
index d7a1714..2c808c2 100644
--- a/Tests/symfonyextension.phpt
+++ b/Tests/symfonyextension.phpt
@@ -1,7 +1,7 @@
 --TEST--
 --SKIPIF--
 <?php
-if (!getenv('SYMFONY_PHPUNIT_VERSION') || version_compare(getenv('SYMFONY_PHPUNIT_VERSION'), '10', '<')) die('Skipping on PHPUnit < 10');
+if (!getenv('SYMFONY_PHPUNIT_VERSION') || version_compare(getenv('SYMFONY_PHPUNIT_VERSION'), '10', '<')) echo 'Skipping on PHPUnit < 10';
 --FILE--
 <?php
 passthru(\sprintf('NO_COLOR=1 php %s/simple-phpunit.php -c %s/Fixtures/symfonyextension/phpunit-with-extension.xml.dist %s/SymfonyExtension.php', getenv('SYMFONY_SIMPLE_PHPUNIT_BIN_DIR'), __DIR__, __DIR__));
diff --git a/Tests/symfonyextensionnotregistered.phpt b/Tests/symfonyextensionnotregistered.phpt
index d52d6bc..aa3d4d3 100644
--- a/Tests/symfonyextensionnotregistered.phpt
+++ b/Tests/symfonyextensionnotregistered.phpt
@@ -1,7 +1,7 @@
 --TEST--
 --SKIPIF--
 <?php
-if (!getenv('SYMFONY_PHPUNIT_VERSION') || version_compare(getenv('SYMFONY_PHPUNIT_VERSION'), '10', '<')) die('Skipping on PHPUnit < 10');
+if (!getenv('SYMFONY_PHPUNIT_VERSION') || version_compare(getenv('SYMFONY_PHPUNIT_VERSION'), '10', '<')) echo 'Skipping on PHPUnit < 10';
 --FILE--
 <?php
 passthru(\sprintf('NO_COLOR=1 php %s/simple-phpunit.php -c %s/Fixtures/symfonyextension/phpunit-without-extension.xml.dist %s/SymfonyExtension.php', getenv('SYMFONY_SIMPLE_PHPUNIT_BIN_DIR'), __DIR__, __DIR__));