Skip to content

Commit

Permalink
feature #54859 [Messenger] Don't mark `EnvelopeAwareExceptionInterfac…
Browse files Browse the repository at this point in the history
…e` internal (valtzu)

This PR was merged into the 7.1 branch.

Discussion
----------

[Messenger] Don't mark `EnvelopeAwareExceptionInterface` internal

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT

As discussed [here](symfony/symfony#54842 (comment)), let's expose `EnvelopeAwareExceptionInterface` to allow custom Messenger middlewares throw a custom exception without causing stamps from previous middlewares being dropped.

Commits
-------

7713fd17f5 Don't mark EnvelopeAwareExceptionInterface internal
  • Loading branch information
fabpot committed May 7, 2024
2 parents 20d1288 + da518e4 commit f73c856
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ CHANGELOG
* Add `--all` option to the `messenger:consume` command
* Add parameter `$jitter` to `MultiplierRetryStrategy` in order to randomize delay and prevent the thundering herd effect
* Add `SIGQUIT` signal among list of signals that gracefully shut down `messenger:consume` and `messenger:failed:retry` commands
* Add `EnvelopeAwareExceptionInterface` for exceptions thrown from middlewares to prevent stamps added by previous middlewares being dropped

7.0
---
Expand Down
3 changes: 0 additions & 3 deletions Exception/EnvelopeAwareExceptionInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@

use Symfony\Component\Messenger\Envelope;

/**
* @internal
*/
interface EnvelopeAwareExceptionInterface
{
public function getEnvelope(): ?Envelope;
Expand Down

0 comments on commit f73c856

Please sign in to comment.