Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 3+ compatibility #159

Open
fabriciojs opened this issue Feb 8, 2019 · 1 comment
Open

Symfony 3+ compatibility #159

fabriciojs opened this issue Feb 8, 2019 · 1 comment

Comments

@fabriciojs
Copy link

I have this bundle used on a Sonata/CMF project, which I am trying to get upgraded from Symfony 2.8 to 3.4 (to eventually hopefully get it to 4.0).

I see it is abandoned for a while now, while other core bundles continue to be updated. So I guess I very much would like an educated suggestion on how to approach this.

My project heavily depends on since all our pages inherits from Symfony\Cmf\Bundle\SimpleCmsBundle\Doctrine\Phpcr\Page (and Sonata admin pages inherits from Symfony\Cmf\Bundle\SimpleCmsBundle\Admin\PageAdmin. That is pretty much what is used from that bundle.

I am looking my alternatives:

  1. Getting this bundle upgraded. I am testing forking and generate a new composer.json with symfony/framework-bundle:>3.0, I get the full set of dependencies installed upon it, but I can't get any testes to run (they basically fail with:
➜  simple-cms-bundle git:(upgrade) ✗ ./vendor/bin/phpunit -vvv
PHPUnit 7.5.4 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.1.19
Configuration: /Users/fabriciojs/Projects/SMS/simple-cms-bundle/phpunit.xml



[]


[Symfony SimpleCmsBundle Test Suite]
EEEEEEE.EE

[PHPCR] Error when initializing dbal:

(any directions on this if possible, very much appreciated)

  1. I might try to refactor out of that bundle Page/Route class, basically rewriting its functionality within my project.

On both of these scenarios I will have to dig further on all related packages version upgrades, which is fun but I guess very much out of scope for my specific project case.

Does anyone have some tips or different ideas on this? Any suggestion on the best approach?

Thanks very much in advance!

@dbu
Copy link
Member

dbu commented Feb 9, 2019

as stated in the readme file, this bundle is unmaintained due to lacking resources in the cmf team. if you still want to dig into it, i am ok to merge a pull request to update the bundle, but i can't spend time digging into it. if you need the combination of route and content that the bundle offers, i guess its about the same effort to update this bundle as it is to understand enough how it works that you can integrate it into your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants