From 88bd5060893663353f70d017698fef8f0fce5d05 Mon Sep 17 00:00:00 2001 From: Steve Boyd Date: Mon, 20 May 2024 17:07:34 +1200 Subject: [PATCH] API Set extension hook implementation visibility to protected --- src/DataObjects/QueuedJobDescriptor.php | 4 ++-- src/Extensions/MaintenanceLockExtension.php | 2 +- src/Extensions/ScheduledExecutionExtension.php | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/DataObjects/QueuedJobDescriptor.php b/src/DataObjects/QueuedJobDescriptor.php index 09e67b64..1012a3f5 100644 --- a/src/DataObjects/QueuedJobDescriptor.php +++ b/src/DataObjects/QueuedJobDescriptor.php @@ -271,7 +271,7 @@ public function cleanupJob() } } - public function onBeforeWrite() + protected function onBeforeWrite() { // if a job is marked as 'waiting' for a restart, we need to reset the // worker it was assigned to, otherwise it'll never pick up and go again if @@ -283,7 +283,7 @@ public function onBeforeWrite() parent::onBeforeWrite(); } - public function onBeforeDelete() + protected function onBeforeDelete() { parent::onBeforeDelete(); $this->cleanupJob(); diff --git a/src/Extensions/MaintenanceLockExtension.php b/src/Extensions/MaintenanceLockExtension.php index c1f15802..61063f15 100644 --- a/src/Extensions/MaintenanceLockExtension.php +++ b/src/Extensions/MaintenanceLockExtension.php @@ -21,7 +21,7 @@ class MaintenanceLockExtension extends DataExtension /** * @param FieldList $fields */ - public function updateCMSFields(FieldList $fields) + protected function updateCMSFields(FieldList $fields) { if (!QueuedJobService::config()->get('lock_file_enabled')) { return; diff --git a/src/Extensions/ScheduledExecutionExtension.php b/src/Extensions/ScheduledExecutionExtension.php index 3eb0861e..05f0c8be 100644 --- a/src/Extensions/ScheduledExecutionExtension.php +++ b/src/Extensions/ScheduledExecutionExtension.php @@ -58,7 +58,7 @@ class ScheduledExecutionExtension extends DataExtension /** * @param FieldList $fields */ - public function updateCMSFields(FieldList $fields) + protected function updateCMSFields(FieldList $fields) { $fields->removeByName([ 'ExecuteInterval', @@ -105,7 +105,7 @@ public function updateCMSFields(FieldList $fields) } } - public function onBeforeWrite() + protected function onBeforeWrite() { parent::onBeforeWrite();