Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Toast - does not close when clicking/keyboard-enter the closing-X button on the right #4292

Closed
1 task
aedu-hostettler opened this issue Dec 15, 2024 · 3 comments · Fixed by #4332
Closed
1 task

[bug]: Toast - does not close when clicking/keyboard-enter the closing-X button on the right #4292

aedu-hostettler opened this issue Dec 15, 2024 · 3 comments · Fixed by #4332
Assignees
@schaertim
Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package
Milestone
Long Term Support

Comments

@aedu-hostettler
Copy link

aedu-hostettler commented Dec 15, 2024 •
edited by gfellerph
Loading

Describe the bug
does not close when clicking/keyboard-enter the closing-X button on the right.

And also add type="button" to the example code on storybook-documentation, otherwise forms are submitted on clicking the x button.

Screenshots
Image

Tasks
Preview Give feedback
@aedu-hostettler aedu-hostettler added the 🐞 bug Something isn't working label Dec 15, 2024
@gfellerph gfellerph added the 📦 styles Related to the @swisspost/design-system-styles package label Dec 16, 2024
@gfellerph gfellerph added this to the Long Term Support milestone Dec 16, 2024
@gfellerph
Copy link
Member

@swisspost/design-system add type=button in the docs.

@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Dec 16, 2024
@aedu-hostettler
Copy link
Author

just as a small additional info: even with type="button" on the closing button, does not close on click/keyboard events.

@gfellerph
Copy link
Member

Similar to #4280, hiding the element on close click should be implemented for the moment. We'll use this ticket to update the documentation.

@schaertim schaertim self-assigned this Dec 18, 2024
@schaertim schaertim moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Dec 18, 2024
@schaertim schaertim linked a pull request Dec 18, 2024 that will close this issue
chore(components): added type=button to prevent form submission #4332
Merged
@schaertim schaertim moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Dec 18, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in Code Review to 🚀 Done in Design System Production Board Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schaertim schaertim

Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Status: 🚀 Done
Milestone
Long Term Support
Development

Successfully merging a pull request may close this issue.

chore(components): added type=button to prevent form submission swisspost/design-system
3 participants
@gfellerph @schaertim @aedu-hostettler