Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Missing border on main navigation mobile #4267

Closed
gfellerph opened this issue Dec 13, 2024 · 1 comment · Fixed by #4301
Closed

[bug]: Missing border on main navigation mobile #4267

gfellerph opened this issue Dec 13, 2024 · 1 comment · Fixed by #4301
Assignees
@leagrdv
Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package
Milestone
PPNL Support

Comments

@gfellerph
Copy link
Member

Describe the bug
A separation border is missing in the main navigation on mobile.

To Reproduce
Image

Expected behavior
There should be the same border between local header (white) and the main navigation (slightly grey) as there is on desktop.

Image
@gfellerph gfellerph added 🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package labels Dec 13, 2024
@gfellerph gfellerph added this to the PPNL Support milestone Dec 13, 2024
@alizedebray
Copy link
Contributor

There is no border in the design: https://www.figma.com/design/JIT5AdGYqv6bDRpfBPV8XR/Foundations-%26-Components-Next-Level?node-id=6505-34282&t=rKuLwShVyhHmK9UR-4

@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Dec 16, 2024
@leagrdv leagrdv self-assigned this Dec 16, 2024
@leagrdv leagrdv moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Dec 16, 2024
@leagrdv leagrdv linked a pull request Dec 16, 2024 that will close this issue
fix(components): add border top main navigation on mobile #4301
Merged
@leagrdv leagrdv moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Dec 16, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in Code Review to 🚀 Done in Design System Production Board Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leagrdv leagrdv

Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package
Projects
Design System Production Board
Status: 🚀 Done
Milestone
PPNL Support
Development

Successfully merging a pull request may close this issue.

fix(components): add border top main navigation on mobile swisspost/design-system
3 participants
@gfellerph @alizedebray @leagrdv