Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform validation icons (between validation in input and assistive text) #4204

Open
leagrdv opened this issue Dec 10, 2024 · 1 comment · May be fixed by #4368
Open

Uniform validation icons (between validation in input and assistive text) #4204

leagrdv opened this issue Dec 10, 2024 · 1 comment · May be fixed by #4368
Assignees
@leagrdv
Labels
📦 styles Related to the @swisspost/design-system-styles package
Milestone
Maintenance III

Comments

@leagrdv
Copy link
Contributor

leagrdv commented Dec 10, 2024

Currently, we have a svg defined at two difference places in the css for the validation icon in the input and the one used in the assistive text. It'd be nice to define it only once.
@gfellerph gfellerph added this to the Maintenance III milestone Dec 11, 2024
@gfellerph gfellerph added the 📦 styles Related to the @swisspost/design-system-styles package label Dec 11, 2024
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Dec 11, 2024
@leagrdv leagrdv assigned leagrdv and unassigned leagrdv Dec 12, 2024
@leagrdv leagrdv self-assigned this Dec 31, 2024
@leagrdv leagrdv moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Dec 31, 2024
@leagrdv leagrdv linked a pull request Dec 31, 2024 that will close this issue
fix(styles): update valid/invalid icons in form fields #4368
Open
@leagrdv
Copy link
Contributor Author

leagrdv commented Dec 31, 2024

Because the icons can only be used as a background image in the input form fields, we can't use it as it's used in the assistive text. However, icons used in the input form fields are not the correct ones and have been updated.

@leagrdv leagrdv moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leagrdv leagrdv

Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Status: 🤬 Dev in Code Review
Milestone
Maintenance III
Development

Successfully merging a pull request may close this issue.

fix(styles): update valid/invalid icons in form fields swisspost/design-system
2 participants
@gfellerph @leagrdv