Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Select | Positive #2194

Closed
wueestd opened this issue Nov 1, 2023 · 4 comments
Closed

Component: Select | Positive #2194

wueestd opened this issue Nov 1, 2023 · 4 comments
Assignees
@Cian77
Labels
✅ approved Review state
Milestone
Design V1

Comments

@wueestd
Copy link

wueestd commented Nov 1, 2023 •
edited by Cian77
Loading

Figma:
https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=7802%3A33963&mode=design&t=VnF7Nfba4zszs6Kt-1

Story Book:
https://next.design-system.post.ch/?path=/docs/components-forms-select--docs

Comments:

  • Updated the complete component as there were quite many issues
  • Added Focus State
  • Updated new Disabled State
  • Added Documentation
@wueestd wueestd converted this from a draft issue Nov 1, 2023
@wueestd wueestd added this to the Design V1 milestone Nov 1, 2023
@wueestd wueestd changed the title Documentation Select Documentation: Select Nov 7, 2023
@Cian77 Cian77 self-assigned this Jan 8, 2024
@Cian77 Cian77 moved this from 📋 Backlog to 🏗 In progress in Design System Production Board Jan 8, 2024
@Cian77
Copy link

Cian77 commented Jan 8, 2024

  • Ad Focus state and check colours
  • Ad documentation

@Cian77 Cian77 changed the title Documentation: Select Component: Select Jan 8, 2024
@Cian77 Cian77 moved this from 🏗 In progress to 👀 In review in Design System Production Board Jan 11, 2024
@Cian77
Copy link

Cian77 commented Jan 11, 2024

Hi Rouven & Philipp, this component is also ready for a review.

@rouvenpost
Copy link

@Cian77 Pattern is ready for Dev

@gfellerph
Copy link
Member

@Cian77 I updated the existing dev ticket #1054, Design looks good to me

@gfellerph gfellerph added the ✅ approved Review state label Jan 22, 2024
@gfellerph gfellerph assigned Cian77 and unassigned Cian77, gfellerph and rouvenpost Jan 22, 2024
@Cian77 Cian77 changed the title Component: Select Component: Select | Positive Feb 1, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Production Board Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cian77 Cian77

Labels
✅ approved Review state
Projects
Design System Production Board
Archived in project
Milestone
Design V1
Development

No branches or pull requests
4 participants
@gfellerph @wueestd @rouvenpost @Cian77