Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Stepper #1962

Closed
3 of 4 tasks
wueestd opened this issue Sep 19, 2023 · 7 comments · Fixed by #3088
Closed
3 of 4 tasks

Documentation: Stepper #1962

wueestd opened this issue Sep 19, 2023 · 7 comments · Fixed by #3088
Assignees
@alizedebray
Labels
✅ approved Review state 📦 components Related to the @swisspost/design-system-components package
Milestone
Design V1

Comments

@wueestd
Copy link

wueestd commented Sep 19, 2023 •
edited by alizedebray
Loading

https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=13414%3A61408&mode=design&t=v21xVVGydMFRQiHB-1

Tasks
Preview Give feedback
  2. Component: Vertical Stepper #954
    request variant 📦 components 🦌 fair game
  3. Update the stepper docs since it does not require ngb progressbar anymore #3089
    📦 documentation
    alizedebray
  4. Simplify the horizontal stepper styles #3090
    💔 BREAKING 📦 styles
@wueestd wueestd converted this from a draft issue Sep 19, 2023
@wueestd wueestd added this to the Design V1 milestone Sep 27, 2023
@wueestd wueestd changed the title Stepper: Documentation Documentation: Stepper Nov 1, 2023
@wueestd
Copy link
Author

wueestd commented Nov 8, 2023

https://design-system.service.gov.uk/patterns/question-pages/#using-progress-indicators

https://design.gs.com/patterns/stepped-progression

https://www.linkedin.com/posts/vitalyfriedman_ux-design-activity-7127577055029796864-0JVK/

@kaloyanso kaloyanso moved this from 📋 Backlog to 🏗 In progress in Design System Production Board Dec 5, 2023
@kaloyanso kaloyanso self-assigned this Dec 5, 2023
@kaloyanso kaloyanso moved this from 🏗 In progress to 👀 In review in Design System Production Board Dec 12, 2023
@kaloyanso
Copy link

Hi @Cian77 and @rouvenpost, could you review this component and the documentation when you have the chance and let me know your thoughts :)

@rouvenpost
Copy link

We should look in to two topic on the Stepped Overview:

  1. Accessibility should be improved. The Dark Grey Circle in the Back is difficult to spot. Try to find a better solution.
  2. The negative Versions are missing. This Pattern must work on White and Grey Backgrounds.

@rouvenpost
Copy link

Stepped Progression:
What about the Mobile approach? How does this Pattern work on Mobile? There are no examples and no documentation for Mobile.

@Cian77
Copy link

Cian77 commented Dec 14, 2023

Hi @kaloyanso, thanks, great work! I only added my comments.

@Cian77 Cian77 moved this from 👀 In review to 📋 Backlog in Design System Production Board Dec 22, 2023
@Cian77 Cian77 removed their assignment Jan 19, 2024
@rouvenpost rouvenpost self-assigned this Feb 2, 2024
@rouvenpost rouvenpost moved this from 📋 Backlog to ✅ Done in Design System Production Board Apr 11, 2024
@gfellerph gfellerph assigned gfellerph and unassigned rouvenpost Apr 12, 2024
@gfellerph gfellerph moved this from ✅ Done to 👀 In review in Design System Production Board Apr 12, 2024
@gfellerph gfellerph assigned alizedebray and unassigned gfellerph Apr 26, 2024
@alizedebray
Copy link
Contributor

@rouvenpost I added some comments directly on Figma

@alizedebray alizedebray assigned rouvenpost and unassigned alizedebray May 2, 2024
@alizedebray alizedebray mentioned this issue May 7, 2024
Closed
@rouvenpost
Copy link

I rebuild the Component. Ready for review.

@alizedebray alizedebray added 📦 components Related to the @swisspost/design-system-components package ✅ approved Review state and removed 🤓 changes requested labels May 14, 2024
@alizedebray alizedebray moved this from 😍 Design in review to 💎 Ready for development in Design System Production Board May 14, 2024
@alizedebray alizedebray self-assigned this May 16, 2024
@alizedebray alizedebray moved this from 💎 Ready for development to 🕹️ Dev in progress in Design System Production Board May 16, 2024
@alizedebray alizedebray linked a pull request May 17, 2024 that will close this issue
chore(styles): update horizontal stepper styles #3088
Merged
@alizedebray alizedebray moved this from 🕹️ Dev in progress to 🤬 Dev in code review in Design System Production Board May 20, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in code review to 🚀 Ready to use (done) in Design System Production Board May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alizedebray alizedebray

Labels
✅ approved Review state 📦 components Related to the @swisspost/design-system-components package
Projects
Design System Production Board
Archived in project
Milestone
Design V1
Development

Successfully merging a pull request may close this issue.

chore(styles): update horizontal stepper styles swisspost/design-system
6 participants
@gfellerph @wueestd @alizedebray @rouvenpost @Cian77 @kaloyanso