Alert to translators #13
Comments
|
I am sorry to react this late. But I found some mistakes in the translation that will probably affect all languages: If I test it there are some phrases that are still in English and that I don't find in the translation repository. Like: or or Then this one: is in my translation, but since it appears double (line 328 and 329) in the english.yaml file I think the translation does not show when I test it. Same for: (line 310 and 311) and (line 470 and 471) But anyway it is nice to be able to test this! Good work! |
|
Do we have to add those lines?
|
|
I think so. And remove the double entry lines. And maybe there are more missing. |
|
Hi @swirldev/translators: The following phrases need to be added for the following languages: |
|
I made a few changes, and @ismaeIfm did the rest. Sorry for the un-cordination hermano |
|
Thanks everyone for the updates! |
|
Hi everyone, testing swirl in spanish I noticed that some lines that were translated here, doesn't showed their respective translation in swirl.
|
|
@ismaeIfm great catch, I'll look into this. |
|
Also I noticed that in Windows the spanish special characters are not correctly displayed in the menu messages of swirl, even though the text with special characters from the .yaml files is correctly displayed (lessons). I've also noticed that swirl adds line breaks between text. Here you can see a comparison between swirl in Linux and swirl in Windows: Here is my output of Sys.getlocale() in Windows 10 in Spanish: [1] "LC_COLLATE=Spanish_Mexico.1252;LC_CTYPE=Spanish_Mexico.1252;LC_MONETARY=Spanish_Mexico.1252;LC_NUMERIC=C;LC_TIME=Spanish_Mexico.1252" This problem is also present in Mac OS but with a proper config of locale is corrected, ie running |
|
Wow, thanks for catching this. I have an idea for a fix. |
|
Try to install the new development version and let me know if the special characters look correct on windows. You'll have uninstall swirl, reinstall swirl with |
|
@seankross thanks to you |
|
Yeah @seankross that solve the special characters issue, but the line breaks keep showing: Now I noticed two more things:
And as it should be: I guess this problem is also present in the names of the courses. I had commented you that I was having some issues with the MANIFEST file when special characters where present. If I created the MANIFEST file (with UTF-8 encoding) in Windows/Linux, when I tried to install the course in Mac OS I had some issues, and vice versa. But I write you a mail more detailed, maybe you want to check at that. |
|
All great catches. What do you get as a result of
|
|
97 |
|
Hmm, I'll check this out on my windows machine at home but it has to do with how a user has that option set. |
|
Curious, cause I've seen these issue in many students using Windows and none in linux or mac. |
|
Does it happen in English? |
|
Yes and even with cran version of swirl: |
|
I can't get the test version up and running on my mac. I uninstalled swirl, and reinstalled it as prescribed, but select_language() was not recognised as a function. It worked with my linux machine however. I got no line breaks. |
|
A brand new version of R recently came out, you may need to install it.
|
|
@seankross ok, downloading it now |
|
OK, it looks good on both my machines, great work people!
|
|
I'm still getting messages generated in response to dependson.txt such as
and
in English, is that to be expected? |
|
@dhduncan that is not to be expected, I will fix it. Thank you! |
|
Encoding issues should now be fixed on the dev branch. You can test it with |
|
@swirldev/translators I really mean it this time: I will be submitting swirl to CRAN on Friday (March 18th). Again a very serious that you to all of you for volunteering your time. |
|
@seankross To me the encoding issues in Windows were not corrected, now they are worse: Should not be corrected this line in Mac OS? |
|
And now in linux I got the following warning: |
|
Make sure you:
And let me know if this persists. On Wed, Mar 16, 2016 at 10:16 PM Ismael Fernández [email protected]
|
|
@seankross to solve which of three issues? |
|
The linux warning and the missing lines in Mac OS are solved, sorry. But the problem with the name lessons (NA) in Windows persists. |
|
Does the NA still persist even with the very newest version? |
|
Yes, this problem has appeared since you update swirl to solved the encoding. Before this updated only the characters were not correctly displayed in Windows. The branch "ismael" of swirl displays the names as the "dev" branch did it (Not correctly but not displayed NA). |
|
I think I used ":" in one of my translated sentences and this might break the translation, too. At least my syntax highlighter suggests that. |
|
This sentence looks like a continuation from another. How does it start? |
|
In english.yaml there is still this duplicate entry I think: This sentence ends with: in line 585 and in line 340. But maybe having this twice is intended. |
|
Hi @nFrechen, I'll check all of that out and make it's working/makes sense. I just figured out the situation with the NAs at lesson selection. Copy the following into a file called test.txt Now compare the results of this code: readLines("test.txt")
readLines("test.txt", encoding = "UTF-8")
x <- readLines("test.txt", encoding = "UTF-8")
writeLines(x, "test2.txt")
writeLines(x, "test2.txt", useBytes = TRUE)Looks like I need to make changes to swirlify as well. swirldev/swirlify#18 |
|
@seankross This is what I get: |
|
It is for sure. The changes have to be made in swirlify.
|
|
Something worth exploring: are the manifest files valid yaml?
|
|
@seankross It is a rhetorical question? |
|
It's a note to self. But if you want to run yaml::yaml.load_file() on a
|
|
I noticed something curious by default Windows in spanish has saved the file "test.text" in ASCII, to get the right encoding I have to tell explicitly to Windows that I want it in UTF-8: |
|
@ismaeIfm I agree. I find it so odd that PCs "born" into Windows in a spanish speaking environment for some reason fail to apply sensible defaults to these files. |
|
I just submitted swirl 2.4.0. I tried to handle the manifest issues as best as possible, unfortunately I think the general guidance will have to be that course authors should stick to ascii in the manifest, however a much wider range of alphabets are supported within the lessons. The general rule is, if your manifest introduces NAs, the manifest gets thrown out. I'm going to close this issue since the next alert to translators will be for the next release of swirl. I expect swirl to follow a very regular release schedule from now on with a patch or release every one or two months. |
@swirldev/translators:
I plan to submit the new version of swirl to CRAN within the next seven days. If there are any changes you would like to make, please make then as soon as possible.
If you would like to see your contributions in action, check out the latest development version of swirl:
Sean
The text was updated successfully, but these errors were encountered: