Skip to content
This repository has been archived by the owner on Aug 7, 2018. It is now read-only.

tests #6

Open
lookfirst opened this issue Feb 11, 2015 · 10 comments
Open

tests #6

lookfirst opened this issue Feb 11, 2015 · 10 comments

Comments

@lookfirst
Copy link
Contributor

this project really needs some tests. =)

@amcdnl
Copy link
Contributor

amcdnl commented Feb 11, 2015

Agreed. Want to handle some while we figure out some of the last holes?

@lookfirst
Copy link
Contributor Author

part of my issue is that i have no idea what this code does. it is some serious magic for me. i can start to try to get the test framework setup?

@lookfirst
Copy link
Contributor Author

ok... working on setting up tests now...

@marjan-georgiev
Copy link
Member

I'm writing a blog post explaining what this does. Should have something by the end of the week. Will let you know.

@lookfirst
Copy link
Contributor Author

ok... just added PR #8

the treewalker is where most of the real magic is... added an empty spec for that...

@lookfirst
Copy link
Contributor Author

There is also a path issue. gulp test in the seed project doesn't work. the issue is finding the bower_components folder as defined as the 'paths' part of system.config.js. The problem is that when we are running a bundle, we need it to be ../bower_components... when we run tests, it needs to just be ./bower_components. Not really sure how to fix that yet. =(

@marjan-georgiev
Copy link
Member

We fixed that in our app today. I updated the seed project. Test framework and 'gulp test' should be working now.

@lookfirst
Copy link
Contributor Author

Couple problems with your fix...

  1. jspm install reorders the system.config.js::map, so it shows up changed in git
  2. gulp test now errors out in gulp-less (update your various npm packages)...
angular-systemjs-seed/node_modules/gulp-less/index.js:68
    }).done(undefined, cb);
       ^
TypeError: Object #<Promise> has no method 'done'

@lookfirst
Copy link
Contributor Author

updating gulp-less to 3.0.0 fixes that issue

@lookfirst
Copy link
Contributor Author

chai also doesn't belong in the system.config.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants