Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another bug in keycloakauthenticator - check_signarure is always true #92

Open
drJabber opened this issue Apr 20, 2024 · 0 comments
Open

Comments

@drJabber
Copy link

drJabber commented Apr 20, 2024

Hello, team
In keycloakauthenticator readme sample there are lines, that could disable signature verification, but this lines dont work, because check_signature is always True

#Configure token signature verification
c.KeyCloakAuthenticator.check_signature=True
c.KeyCloakAuthenticator.jwt_signing_algorithms = ["HS256", "RS256"]

I think this behavior could be fixed if in lines
if self.config.check_signature :
jwks_uri = data['jwks_uri']

and
if not self.config.check_signature:
options.update({"verify_signature": False})

you could change self.config.check_signature to self.check_signature

Could you please also fix this
or maybe I could make a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant