Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data validation - Dates #92

Open
PhilipeRLeal opened this issue Dec 23, 2024 · 3 comments
Open

Data validation - Dates #92

PhilipeRLeal opened this issue Dec 23, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@PhilipeRLeal
Copy link
Contributor

PhilipeRLeal commented Dec 23, 2024

Dear developers,

First of all, I would like to thank you for such an amazing package.

Recently, I have been investigating how to use SpreadCheetah to create some local Excel files. In my study, I noticed that SpreadCheetah does not implement boundary validation for DateOnly and/or DateTime objects; so far, I could only find solutions for numerical boundary problems.

Therefore, I would like to suggest a DateTime and a DateOnly Boundary validators to the available package options.

Sincerely,

@sveinungf
Copy link
Owner

Thanks for the feedback!

What kind of boundary validation are you looking for? Are you thinking about the case that dates must be greater than January 1, 1900?

@PhilipeRLeal
Copy link
Contributor Author

Dear Sveinungf,

Precisely the case.

Excel files do support all kinds of boundary value types (decimal value, integer value, date-only, date-time, etc.), and boundary rules (greater than, greater or equal than, between, lower than, and lower or equal than) validations. Therefore, It would be most welcoming to have these functionalities available within SpreadCheetah.

Sincerely,

@sveinungf
Copy link
Owner

Ah yes, now I understand. So in practical terms it would be to extend the DataValidation class with e.g. DataValidation.DateGreaterThan and similar. That part is missing now but it sure could be a useful feature. Thanks for the suggestion!

@sveinungf sveinungf changed the title Implementation of DateOnly and DateTime boundary Validators Data validation - Dates Dec 23, 2024
@sveinungf sveinungf added the enhancement New feature or request label Dec 23, 2024
@sveinungf sveinungf added this to the v1.20.0 milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants