Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review HDF5 dependencies #921

Closed
gonuke opened this issue Nov 30, 2023 · 4 comments · Fixed by #931
Closed

Review HDF5 dependencies #921

gonuke opened this issue Nov 30, 2023 · 4 comments · Fixed by #931

Comments

@gonuke
Copy link
Member

gonuke commented Nov 30, 2023

We currently are pegged to a certain HDF5 version for historical reasons, as well as to allow the default ubuntu version.

We should reevaluate our strategy, particularly after #916 has been addressed.

@ahnaf-tahmid-chowdhury
Copy link
Member

As the latest builds are passing, should we update HDF5 to latest? Please note, MOAB is still set to 5.3.0 as @pshriwise explained us the issue of 5.5.x before.

@gonuke
Copy link
Member Author

gonuke commented Dec 20, 2023

I think it's worth a PR to use a newer HDF5

@ahnaf-tahmid-chowdhury
Copy link
Member

I can make a PR. Before that I have a few questions. Do you like to use the latest version of hdf5 1.14.3 from the source? Or want to use the default hdf5 (1.12.1) that comes with Ubuntu (22.04)? If we go with Ubuntu version, are we planning to use the binary version of hdf5 instead of installing from the source?

@gonuke
Copy link
Member Author

gonuke commented Dec 20, 2023

I think we should build from source with the newest version that works (1.14.3). We used to test with both the default and optionally a newer version, but the default versions are getting to be too old.

@ahnaf-tahmid-chowdhury ahnaf-tahmid-chowdhury linked a pull request Dec 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants