bug: macro function in DAGMCExportCommand.cpp

[qingfengxia]

#define CHK_MB_ERR_RET_MB(A,B)  if (moab::MB_SUCCESS != (B)) { \
  message << (A) << (B) << std::endl;                                   \
  return rval;                                                         \
  }

Wont return A or B instead of rval, which is not in the parameter list?

Although, it does not report error during compiling.

[makeclean]

This macro is to be used where, A is your message to print on failure, B is the return value from some function, this is compared against success, and maybe it should return B instead of rval?

[makeclean]

its inherited from MOAB

[gonuke]

I'll have to double check and see if MOAB has the same issue, but I think it should return B

[gonuke]

Also, it doesn't report an error because it is always called immediately after evaluating rval and it is in scope