Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Feature request: New check endpoint / agents module #13

Closed
nwerker opened this issue Sep 28, 2023 · 2 comments
Closed

✨ Feature request: New check endpoint / agents module #13

nwerker opened this issue Sep 28, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request work in progress

Comments

@nwerker
Copy link
Member

nwerker commented Sep 28, 2023

Suggest an idea for this project

SUMMARY

There should be a new module which checks a number of agents / endpoints against the S1 API. It should check is the endpoint registred, has a desired status (active true or false), is correctly in a given set of sites and maybe if the agent is unique. Through additional fields the API Call can be customized by the user.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

sentinelone_check_endpoint.py
sva.sentinelone.sentinelone_check_endpoint

ADDITIONAL INFORMATION

This could be a list of input parameters:

    module_args = dict(
        console_url=dict(type='str', required=True),
        token=dict(type='str', required=True, no_log=True),
        endpoints=dict(type='list', required=True, elements='str'),
        sites=dict(type='list', required=False, elements='str'),
        active=dict(type='bool', required=False),
        unique=dict(type='bool', required=False),
        additional_fields=dict(type='dict', required=False, elements='str')
    )
- name: "Check if agent is registred correctly
  sva.sentinelone.sentinelone_check_endpoint:
    console_url="https://XYZ.sentinelone.net"
    token="XXXXXXXXXXXXXX"
    endpoints:
      - "my_computer01"
    active: true

- name: "Check if list of endpoints is registered correctly
  sva.sentinelone.sentinelone_check_endpoint:
    console_url="https://XYZ.sentinelone.net"
    token="XXXXXXXXXXXXXX"
    endpoints:
       - "my_computer01"
       - "tims_desktop01"
       - "farm_server04"
    sites:
       - "my_site01"   

Return Values should be the return by the API and the state of the module should be dictated by the input parameters. e.g: Fail if the endpoint is registered but in more or less sites than expected. Or fail if the endpoints don't match the active state. This can be used to check if the agent is registered correctly. For instance after an automatic installation

@nwerker nwerker added enhancement New feature or request work in progress labels Sep 28, 2023
@nwerker nwerker self-assigned this Sep 28, 2023
@mwester117
Copy link
Collaborator

We will not create a new ansible module for this purpose. We included this functionality in the new install_agent role.

See #25 for details.

@nwerker
Copy link
Member Author

nwerker commented Mar 27, 2024

Issue closed, since feature is implemented in role instead of dedicated module

@nwerker nwerker closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request work in progress
Projects
None yet
Development

No branches or pull requests

2 participants