Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Github Enterprise #300

Closed
mechastorm opened this issue May 24, 2022 · 6 comments
Closed

Support for Github Enterprise #300

mechastorm opened this issue May 24, 2022 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@mechastorm
Copy link

Would it be possible for this tool to post a comment on a Github Enterprise installation instead? From the looks of this, it seems to be only for Github.com and I do not see any option to specify the GITHUB_URL.

Similar to this mercari/tfnotify issue mercari/tfnotify#91

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label May 24, 2022
@suzuki-shunsuke
Copy link
Owner

suzuki-shunsuke commented May 24, 2022

Thank you for your feedback.
Could you try to set ghe_base_url in tfcmt.yaml?

e.g. tfcmt.yaml

ghe_base_url: https://example.com

I don't use GitHub Enterprise, so I can't confirm if it works well.

@suzuki-shunsuke suzuki-shunsuke removed the enhancement New feature or request label May 24, 2022
@mechastorm
Copy link
Author

mechastorm commented May 24, 2022

Thank you very much! I can confirm that this works in GHE with the suggested config

For other references, my tfcmt.yaml config is just like so

ghe_base_url: https:// 

And i can then run the command like so tfcmt --config tfcmt.yaml plan -- terraform plan

@suzuki-shunsuke
Copy link
Owner

suzuki-shunsuke commented May 25, 2022

Oh, I found that we have to fix GitHub API v4 to support GitHub Enterprise.
GitHub API v4 is used to update pull request comment.
https://suzuki-shunsuke.github.io/tfcmt/plan-patch

@suzuki-shunsuke
Copy link
Owner

#304

@suzuki-shunsuke suzuki-shunsuke added the bug Something isn't working label May 25, 2022
@suzuki-shunsuke suzuki-shunsuke added this to the v3.2.3 milestone May 25, 2022
@suzuki-shunsuke
Copy link
Owner

Released https://github.com/suzuki-shunsuke/tfcmt/releases/tag/v3.2.3

I don't use GitHub Enterprise, so I can't confirm if it works well for GitHub Enterprise.
I really appreciate if you confirm if it works well.

tfcmt plan -patch -- terraform plan -no-color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants