Thank you for your feedback!
This feedback makes sense.

I think we can change wrapCode function if tfcmt writes the result to a local file.

• fix: wrapCode no longer trancate long output if tfcmt outputs the result to a local file #1309

Thank you for your feedback! This feedback makes sense.

I think we can change wrapCode function if tfcmt writes the result to a local file.

tfcmt/pkg/notifier/localfile/plan.go

Line 55 in 898a491

body, err := template.Execute()

tfcmt/pkg/terraform/template.go

Line 170 in 898a491

"wrapCode": wrapCode,

Hmm, this depends on how to use a local file.
If users edit the file and post it to GitHub, wrapCode should trancate long result.
IIRC, I heard some people use --output option to put together multiple results to one comment.
So as you said, maybe an option to switch behaviour is necessary. 🤔

Awesome, thanks for the quick reply!

If other people put together multiple results in one comment I think they might need to do truncation anyway in case the individual files do not exceed the limit but the combined one does? In that case an option would not help much (but that would be the case with the current implementation and with the one in the PR)

Thanks for picking this up, are there any updates on this? Anything I can still help out with?

With the wrapCode, is that i need to produce the output file without the wrapCode first, check the size of the output and then produce output again with-or-without (if-else) wrapCode based on the output size so that it will fit into my specific limit?