Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JUCE link from the chow dsp effects #7879

Open
baconpaul opened this issue Nov 29, 2024 · 2 comments
Open

Remove JUCE link from the chow dsp effects #7879

baconpaul opened this issue Nov 29, 2024 · 2 comments
Labels
Feature Request New feature request

Comments

@baconpaul
Copy link
Collaborator

We should just do this in 1.4.0

It also means we can clean up the CMakeList in surge-common to not have the fake juce in rack.

@baconpaul baconpaul added the Feature Request New feature request label Nov 29, 2024
@baconpaul baconpaul added this to the Surge XT 1.4.0 milestone Nov 29, 2024
@baconpaul
Copy link
Collaborator Author

paul ~/dev/music/surge/src/common (minor-up) % grep -r juce:: .               
./CMakeLists.txt:  add_library(juce::juce_dsp ALIAS juce_dsp_rack_sub)
./CMakeLists.txt:  juce::juce_dsp
./SurgeSynthesizer.h:    // patchLoadedListener calls OSCSender::send(), which runs on a juce::MessageManager thread.
./dsp/effects/chowdsp/shared/chowdsp_DelayLine.h:    virtual void prepare(const juce::dsp::ProcessSpec & /* spec */) = 0;
./dsp/effects/chowdsp/shared/chowdsp_DelayLine.h:            bufferData = juce::dsp::AudioBlock<SampleType>(dataBlock, numChannels, numSamples);
./dsp/effects/chowdsp/shared/chowdsp_DelayLine.h:    juce::HeapBlock<char> dataBlock;
./dsp/effects/chowdsp/shared/chowdsp_DelayLine.h:    juce::dsp::AudioBlock<SampleType> bufferData;
./dsp/effects/chowdsp/shared/chowdsp_DelayLine.h:    void prepare(const juce::dsp::ProcessSpec &spec) final;
./dsp/effects/chowdsp/shared/chowdsp_DelayLine.cpp:    totalSize = juce::jmax(4, maximumDelayInSamples + 1);
./dsp/effects/chowdsp/shared/chowdsp_DelayLine.cpp:    jassert(juce::isPositiveAndNotGreaterThan(newDelayInSamples, upperLimit));
./dsp/effects/chowdsp/shared/chowdsp_DelayLine.cpp:    delay = juce::jlimit((NumericType)0, upperLimit, newDelayInSamples);
./dsp/effects/chowdsp/shared/chowdsp_DelayLine.cpp:void DelayLine<SampleType, InterpolationType>::prepare(const juce::dsp::ProcessSpec &spec)
./dsp/effects/chowdsp/shared/chowdsp_DelayLine.cpp:        juce::dsp::AudioBlock<SampleType>(this->dataBlock, spec.numChannels, 2 * (size_t)totalSize);
./dsp/effects/chowdsp/spring_reverb/SpringReverbProc.cpp:    delay.prepare({sampleRate, (juce::uint32)samplesPerBlock, 2});
./dsp/effects/chowdsp/spring_reverb/ReflectionNetwork.h:            d.prepare({sampleRate, (juce::uint32)samplesPerBlock, 2});
./dsp/effects/chowdsp/spring_reverb/SpringReverbProc.h:    using VecType = juce::dsp::SIMDRegister<float>;

@baconpaul
Copy link
Collaborator Author

This is a really fiddly thing to do tho. Need a rainy day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature request
Projects
None yet
Development

No branches or pull requests

1 participant