FreeBSD / Clang18 build fails: error: use of infinity is undefined behavior due to the currently enabled floating-point options [-Werror,-Wnan-infinity-disabled]

[yurivict]

Bug Description:

In file included from /wrkdirs/usr/ports/audio/surge-synthesizer-xt-lv2/work/surge-release_xt_1.3.2/libs/fmt/src/os.cc:13:
In file included from /wrkdirs/usr/ports/audio/surge-synthesizer-xt-lv2/work/surge-release_xt_1.3.2/libs/fmt/include/fmt/os.h:16:
/wrkdirs/usr/ports/audio/surge-synthesizer-xt-lv2/work/surge-release_xt_1.3.2/libs/fmt/include/fmt/format.h:2747:23: error: use of infinity is undefined behavior due to the currently enabled floating-point options [-Werror,-Wnan-infinity-disabled]
 2747 |   constexpr T inf = T(std::numeric_limits<double>::infinity());
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Surge XT Version
1.3.2

• Version: 1.3.2 amd64

Reproduction Steps:
regular build

Computer Information (please complete the following!):

• OS: FreeBSD 14.1
• Compiler: clang-18

log

[baconpaul]

Which compiler are you using? Thanks

[baconpaul]

Oh I see you say that. Clang 18.

[yurivict]

-Wno-nan-infinity-disabled is a workaround.

[baconpaul]

So in a bit of a mystery, using clang-18.1 on windows I don't get any error building surge at head.

I havent' tried on linux - we just fixed our pipeline actions to use 18.1

[yurivict]

So in a bit of a mystery, using clang-18.1 on windows I don't get any error building surge at head.

The c++ library that is used impacts errors generated by clang.

[baconpaul]

Yeah definitely a libc or other os provided dep generating the error not on of our deps.

[yurivict]

You can easily reproduce the problem using these steps:

1. Install the FreeBSD VM image into VirtualBox.
2. Boot FreeBSD
3. Install git: pkg install git
4. Check out the ports tree: git clone https://git.FreeBSD.org/ports.git /usr/ports
5. cd /usr/ports/audio/surge-synthesizer-xt-lv2
6. Install dependencies: pkg install -A `make missing`
7. Build: make

The options mitigating the problem are in the Makefile there.

[baconpaul]

Is that an ironic use of the word easily? ;)

[yurivict]

It's easy because there are well-described steps without much chance of failure.
Compare this to the situation when original research is needed with many unknowns.