-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic builds for apple silicon fix #4165
base: master_dev
Are you sure you want to change the base?
Conversation
merged. |
@supermerill great! your project is super. |
I run a build, and the arm version still don't compile. seems like it can't find wxwidget. I wonder why... should i just try again? |
@supermerill let me give a look, it seems I cannot see logs, I have no rights |
I have, there is the action menu on top. |
4768d04
to
97c0256
Compare
I can replicate, let me investigate. It's strange as on my local machine I can build apple silicon correctly. https://drive.google.com/file/d/13fBXLvJVzxQodDBJMR6MtyiczQGQSYzn/view?usp=sharing Leave it with me. I will solve. |
Bingo! https://github.com/glsorre/SuperSlicer/actions/runs/8095431632/job/22122105390 The problem is libTIFF shasum check. Look at deps/TIFF/TIFF.cmake Sorry but i forgot to put this change in the PR. |
It does not build with the |
Bingo2! https://github.com/glsorre/SuperSlicer/actions/runs/8112691883 This solves the nlopt problem on the debug builds. I am not a super expert of cmake so please evaluate if the change can have an impact on other platforms. |
This small patch solves the problem with iconv not recognised during boost::locale build on apple silicon.
Furthermore it fixes the build on macOS Sonoma with latest Xcode.