Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/depot #67

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat/depot #67

wants to merge 5 commits into from

Conversation

roelofb
Copy link

@roelofb roelofb commented Oct 7, 2024

Opt-out of Depot builds

@jrr
Copy link

jrr commented Oct 28, 2024

For anyone wondering whether superfly/fly-pr-review-apps ought to support --depot=false, we worked around a depot outage today using this PR's fork. We were seeing this in our CI:

==> Building image
Waiting for depot builder...

==> Building image
Waiting for depot builder...

Error: failed to fetch an image or build from source: error building: context deadline exceeded

Then adjusted our CI config like so:

# before:
      - id: fly-deploy
        name: Deploy Fly Preview App
        uses: superfly/[email protected]

# after:
      - id: fly-deploy
        name: Deploy Fly Preview App
        uses: rb2-bv/fly-pr-review-apps@07c98ac844f1f99ea70ed9a71291e6b195dd2f2e
        with:
          depot: false

With this in place, the legacy builder worked fine:

==> Building image
Waiting for remote builder fly-builder-black-waterfall-853...

Remote builder fly-builder-black-waterfall-853 ready

Thanks @roelofb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants