-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idea: clean up Builder UI #149
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright Tests tests failed after 19m 7s Run Details
This message was posted automatically by
currents.dev | Integration Settings
|
I'm torn, on one side it is less context for each step but now we have more steps. This would be a good A/B test imo! Anyways, since we have scrolling in the sidebar, maybe scrolling should move you to the next tab. Or having an arrow + progress bar to show that you are moving forward. Sense of progression and hinting of direction in tabs could be improved imo. |
the NFT tab is on the way too. Though we don't have a big enough sample-size for A/B testing |
}, | ||
i, | ||
) => ( | ||
<Zoom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different delay based on index would look awesome. Index * 100 or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean and it's a cool idea but it's slightly more complicated.
The main use for the animation is to animate the latest payment option that was added. The last one to be added has the highest index.
It will show up on top though as I reverse the list after the .map
call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll die of conflict overload probably, but lgtm
apps/widget-builder/src/components/payment-option-view/PaymentOptionView.tsx
Outdated
Show resolved
Hide resolved
const demoStyling: DisplaySettings = { | ||
...defaultDisplaySettings, | ||
darkMode: faker.datatype.boolean(), | ||
primaryColor: faker.color.rgb() as `#${string}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
faker generates random values right? I would use default values instead because faker could generate some really ugly configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, it's fun. I'm open to adding a "Reset default theme" button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix tests and issues in other PRs
Makes more sense this way, IMO. Thoughts?