Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: clean up Builder UI #149

Merged
merged 21 commits into from
Aug 31, 2023
Merged

Conversation

kasparkallas
Copy link
Collaborator

Makes more sense this way, IMO. Thoughts?

@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
widget-b2b-service-demo 🛑 Canceled (Inspect) Aug 31, 2023 9:22am
widget-builder ✅ Ready (Inspect) Visit Preview Aug 31, 2023 9:22am
widget-donation-demo 🛑 Canceled (Inspect) Aug 31, 2023 9:22am
widget-gated-community-demo 🛑 Canceled (Inspect) Aug 31, 2023 9:22am
widget-hosted 🛑 Canceled (Inspect) Aug 31, 2023 9:22am
widget-reference-docs ✅ Ready (Inspect) Visit Preview Aug 31, 2023 9:22am

@currents-bot
Copy link

currents-bot bot commented Aug 24, 2023

Playwright Tests tests failed after 19m 7s

🟢 8 · 🔴 7 · ⚪️ 0 · 🟣 1

View Run Details

Run Details

  • Project: Widget

  • Groups: 1

  • Framework: Playwright

  • Run Status: Failed

  • Commit: bd78d28

  • Spec files: 2

  • Overall tests: 15

  • Duration: 19m 7s

  • Parallelization: 1

Failed Spec Files

Spec File Failures
widget.spec.ts 4
builder.spec.ts 3


This message was posted automatically by currents.dev | Integration Settings

@philipandersson
Copy link
Contributor

I'm torn, on one side it is less context for each step but now we have more steps. This would be a good A/B test imo!

Anyways, since we have scrolling in the sidebar, maybe scrolling should move you to the next tab. Or having an arrow + progress bar to show that you are moving forward. Sense of progression and hinting of direction in tabs could be improved imo.

@tokdaniel
Copy link
Contributor

tokdaniel commented Aug 26, 2023

I'm torn, on one side it is less context for each step but now we have more steps. This would be a good A/B test imo!

Anyways, since we have scrolling in the sidebar, maybe scrolling should move you to the next tab. Or having an arrow + progress bar to show that you are moving forward. Sense of progression and hinting of direction in tabs could be improved imo.

the NFT tab is on the way too. Though we don't have a big enough sample-size for A/B testing

@vercel vercel bot temporarily deployed to Preview – widget-hosted August 31, 2023 08:48 Inactive
@vercel vercel bot temporarily deployed to Preview – widget-reference-docs August 31, 2023 08:48 Inactive
@vercel vercel bot temporarily deployed to Preview – widget-gated-community-demo August 31, 2023 08:48 Inactive
@vercel vercel bot temporarily deployed to Preview – widget-donation-demo August 31, 2023 08:48 Inactive
@vercel vercel bot temporarily deployed to Preview – widget-b2b-service-demo August 31, 2023 08:48 Inactive
},
i,
) => (
<Zoom
Copy link
Contributor

@Mikkoun Mikkoun Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different delay based on index would look awesome. Index * 100 or something

Copy link
Collaborator Author

@kasparkallas kasparkallas Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean and it's a cool idea but it's slightly more complicated.

The main use for the animation is to animate the latest payment option that was added. The last one to be added has the highest index.

It will show up on top though as I reverse the list after the .map call.

Copy link
Contributor

@tokdaniel tokdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll die of conflict overload probably, but lgtm

const demoStyling: DisplaySettings = {
...defaultDisplaySettings,
darkMode: faker.datatype.boolean(),
primaryColor: faker.color.rgb() as `#${string}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faker generates random values right? I would use default values instead because faker could generate some really ugly configurations.

Copy link
Collaborator Author

@kasparkallas kasparkallas Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, it's fun. I'm open to adding a "Reset default theme" button.

@vercel vercel bot temporarily deployed to Preview – widget-b2b-service-demo August 31, 2023 09:21 Inactive
@vercel vercel bot temporarily deployed to Preview – widget-donation-demo August 31, 2023 09:21 Inactive
@vercel vercel bot temporarily deployed to Preview – widget-gated-community-demo August 31, 2023 09:21 Inactive
@vercel vercel bot temporarily deployed to Preview – widget-hosted August 31, 2023 09:21 Inactive
Copy link
Contributor

@elvijsTDL elvijsTDL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix tests and issues in other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SUBS] Horizontal widget breaks when using the magic wand for payment options [SUBS] Clean up Builder UI
7 participants