Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SENTINEL] Use protocol deployment script for Sentinel #286

Open
1 task
philipandersson opened this issue Oct 16, 2023 · 3 comments
Open
1 task

[SENTINEL] Use protocol deployment script for Sentinel #286

philipandersson opened this issue Oct 16, 2023 · 3 comments
Assignees
Labels
Project: SENTINEL Tag: TechDebt Technical debt that needs to be addressed Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Type: Testing Testing cases or harness improvements

Comments

@philipandersson
Copy link

  • Sort out dependencies in ethereum-contracts.
@philipandersson philipandersson added Project: SENTINEL Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps labels Oct 16, 2023
@philipandersson
Copy link
Author

@0xdavinchee please sync with @d10r to unblock Sentinel GDA PR.

@hellwolf hellwolf added the Type: Testing Testing cases or harness improvements label Oct 17, 2023
@d10r
Copy link
Collaborator

d10r commented Oct 19, 2023

@0xdavinchee will provide a blueprint for how to do this, may require changes in protocol-monorepo.

We discussed how to minimize constraints put on the consuming application. Right now there's the following issues:

  • The ethereum-contracts package doesn't specify the dependencies needed by dev-scripts/deploy-test-framework.js in its own package.json. Specifically hardhat and hardhat-ethers, which are required by that script, aren't included, they are instead included in the monorepo's root package.json. We don't know why that is. Those dependencies should either be moved to or duplicated into the ethereum-contract package.json. Open question: do they belong into "dependencies" or "peerDependencies"?
  • The project using the deploy script may itself be a hardhat project and may use a different version, e.g. hardhat with ethers-v6 (which the deployment script expects ethers-v5). The script gets some objects provided by hardhat-ethers, e.g. here. If it just uses the hardhat environment provided by the consuming application, those objects may not have the shape the scripts expects in case of version mismatch. Thus even if the consuming application uses hardhat, it may be better for the deploy script to create its own hardhat environment and ethers objects. Currently open question: what should the interface look like? Right now it's just deployTestFramework with no arguments provided (but making assumptions about a pre-existing global environment).

@philipandersson philipandersson added the Tag: TechDebt Technical debt that needs to be addressed label Oct 20, 2023
@philipandersson
Copy link
Author

We have a Fransktein's monster of a current setup for deployment. We are not blocked by this but it would be nice to align deployment scripts. We consider this tech debt for now.

@hellwolf hellwolf transferred this issue from another repository Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: SENTINEL Tag: TechDebt Technical debt that needs to be addressed Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Type: Testing Testing cases or harness improvements
Projects
None yet
Development

No branches or pull requests

5 participants