Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sentinel] - Discussion to remove listed token option #228

Open
ngmachado opened this issue Jun 10, 2023 · 0 comments
Open

[Sentinel] - Discussion to remove listed token option #228

ngmachado opened this issue Jun 10, 2023 · 0 comments
Assignees
Labels
Tag: Help Me Whelp! extra attention is needed here Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps

Comments

@ngmachado
Copy link
Collaborator

The current usage of Listen Token in our system seems to be a legacy artefact from an time when we did not have the necessary features for detailed token filtering.

This feature introduces additional complexity to our codebase, which can potentially lead to maintenance challenges and impact readability.

At the moment, all tokens can be listed simply by making a pull request, making the Listen Token feature somewhat redundant. We should consider whether the Listen Token feature is still relevant in our current context, or whether alternative mechanisms might be more suitable for our needs.

@ngmachado ngmachado added the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Jun 10, 2023
@ngmachado ngmachado self-assigned this Jun 10, 2023
@hellwolf hellwolf added the Tag: Help Me Whelp! extra attention is needed here label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: Help Me Whelp! extra attention is needed here Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps
Projects
None yet
Development

No branches or pull requests

2 participants