Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] New Superfluid BatchCall Operation: ERC-2771 "forwardCall" #478

Closed
hellwolf opened this issue Nov 4, 2021 · 3 comments
Closed

[ETHEREUM-CONTRACTS] New Superfluid BatchCall Operation: ERC-2771 "forwardCall" #478

hellwolf opened this issue Nov 4, 2021 · 3 comments
Assignees
@0xdavinchee
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Resolution: Duplicate This issue or pull request already exists Tag: Idea Raw idea, questions, thoughts and brainstorming notes
Milestone
ethereum-contrac...

Comments

@hellwolf
Copy link
Contributor

hellwolf commented Nov 4, 2021

As a developer, since many contract supports EIP-2771 style of context that eodes msg.sender (one that's popularized by OZ GSN), it would be very helpful if Superfluid batch call supports it.

Spec

Let's call it callWith2771Context, operationType 301, where the real msg.sender is packed as EIP2771 context and externall call the target with it.

Notes for developer

  • As a contract developer, I can override OZ's ERC2771Context in order to support multiple trusted forwarder, or just one by default.
  • And in order to make batchCall work, the superfluid host contract should be the trusted forwarder.
@hellwolf hellwolf added the Type: Enhancement New feature or request label Nov 4, 2021
@0xdavinchee 0xdavinchee added Tag: Idea Raw idea, questions, thoughts and brainstorming notes and removed Type: Enhancement New feature or request labels Jan 7, 2022
@hellwolf
Copy link
Contributor Author

@0xdavinchee

@hellwolf
Copy link
Contributor Author

spike: #1181

@hellwolf hellwolf added this to the [email protected] - Giga milestone Nov 21, 2022
@hellwolf hellwolf changed the title [ETHEREUM-CONTRACTS] New Superfluid BatchCall Operation: eip-2771 [ETHEREUM-CONTRACTS] New Superfluid BatchCall Operation: eip-2771 "forwardCall" Dec 6, 2022
@hellwolf hellwolf added the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Aug 23, 2023
@hellwolf hellwolf added the Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity label Jan 18, 2024
@hellwolf hellwolf removed the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Mar 11, 2024
@hellwolf hellwolf changed the title [ETHEREUM-CONTRACTS] New Superfluid BatchCall Operation: eip-2771 "forwardCall" [ETHEREUM-CONTRACTS] New Superfluid BatchCall Operation: ERC-2771 "forwardCall" Mar 13, 2024
@hellwolf hellwolf mentioned this issue Mar 15, 2024
Closed
13 tasks
@hellwolf
Copy link
Contributor Author

Superceded by #1895.

@hellwolf hellwolf added the Resolution: Duplicate This issue or pull request already exists label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xdavinchee 0xdavinchee

Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Resolution: Duplicate This issue or pull request already exists Tag: Idea Raw idea, questions, thoughts and brainstorming notes
Projects
None yet
Milestone
[email protected] - Giga
Development

No branches or pull requests
2 participants
@hellwolf @0xdavinchee