Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS-SDK] defunct actions in User.js #2034

Open
d10r opened this issue Oct 29, 2024 · 1 comment
Open

[JS-SDK] defunct actions in User.js #2034

d10r opened this issue Oct 29, 2024 · 1 comment
Labels
Tag: TechDebt Technical debt that needs to be addressed

Comments

@d10r
Copy link
Collaborator

d10r commented Oct 29, 2024

What & Why

When working on #2032, it was noticed that in https://github.com/superfluid-finance/protocol-monorepo/blob/dev/packages/js-sdk/src/User.js#L102 there's code which superficially looks like GDA wrapping, but invokes IDA functionality. It's likely broken and to be removed.
@d10r d10r added the Tag: TechDebt Technical debt that needs to be addressed label Oct 29, 2024
@hellwolf
Copy link
Contributor

Who is using the JS-SDK for that? It's been deprecated, and only our own dev/ops-scripts are using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tag: TechDebt Technical debt that needs to be addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hellwolf @d10r