[ETHEREUM-CONTRACTS] Investigate 64/64 rule failure with try/catch #1898
Labels
Project: PROTOCOL-EVMv1
Superfluid protocol EVM v1 implementation in Solidity
Tag: Quality
Related to the quality topic
Team: Protocol
Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps
What & Why
When working on #1879, 2 mitigations other than removing the try/catch were attempted
originally was followed by a call
and by an
if
statement.So the assumption was that taking the snapshot as last instruction before the try would solve the problem.
But this turned out to not be the case, the test still failed.
Thus I locally tried to replace it with low-level calls, following the implementation done for SuperApp callbacks (see here). To my surprise, it still failed. However I was focused on getting the task done (vs understanding what exactly was happening), which in case of the FlowNFTs could be achieved by simply not allowing reverts. So what I was seeing could have been a red herring.
However we want to keep track of this and eventually figure out what exactly was the issue here, so we can avoid it causing troubles in other occasions.
AC
The text was updated successfully, but these errors were encountered: