Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROTOCOL-OPS] check (again) biconomy addresses #1863

Open
2 tasks
d10r opened this issue Apr 20, 2023 · 1 comment
Open
2 tasks

[PROTOCOL-OPS] check (again) biconomy addresses #1863

d10r opened this issue Apr 20, 2023 · 1 comment
Assignees
Labels
Tag: TechDebt Technical debt that needs to be addressed Type: Spike Task that is to be timeboxed

Comments

@d10r
Copy link
Collaborator

d10r commented Apr 20, 2023

Issue

We have biconomy set as trusted forwarders.
Somewhen last year we checked those, checking if they are all verified, trying to figure out what exactly is deployed, what's audited etc.
Turned out the biconomy guys themselves didn't know exactly what was deployed where, making it difficult to assess how trustworthy we should consider those contracts to be. Which isn't a small issue, bcs trusted forwarders basically have root access to our protocol.
Some more context: #1083

Tasks

  • Reminder for a future check, hoping that biconomy has their contracts in a better order
  • Alternatively remove permission if they're not needed / used anymore.
@d10r d10r added the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Apr 20, 2023
@vmichalik vmichalik transferred this issue from superfluid-finance/protocol-monorepo Jun 13, 2023
@hellwolf hellwolf self-assigned this Aug 24, 2023
@hellwolf hellwolf added the Type: Spike Task that is to be timeboxed label Aug 24, 2023
@hellwolf hellwolf changed the title check (again) biconomy addresses [PROTOCOL-OPS] check (again) biconomy addresses Aug 24, 2023
@hellwolf hellwolf added the Tag: TechDebt Technical debt that needs to be addressed label Aug 24, 2023
@hellwolf hellwolf transferred this issue from another repository Mar 5, 2024
@hellwolf hellwolf removed the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Mar 11, 2024
@hellwolf
Copy link
Contributor

It would be good to use superfluid-finance/superfluid-explorer#222 to validate eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: TechDebt Technical debt that needs to be addressed Type: Spike Task that is to be timeboxed
Projects
None yet
Development

No branches or pull requests

2 participants