Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HackDays DevX Friction Points #1659

Closed
0xdavinchee opened this issue Sep 5, 2023 · 2 comments
Closed

HackDays DevX Friction Points #1659

0xdavinchee opened this issue Sep 5, 2023 · 2 comments
Labels
Tag: TechDebt Technical debt that needs to be addressed Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps

Comments

@0xdavinchee
Copy link
Contributor

0xdavinchee commented Sep 5, 2023 •
edited
Loading

A list of friction points experienced when building on Superfluid during hack days:

  • Having to use a super app for call app action (see related)
  • Not supporting permit in our TestToken ([ETHEREUM-CONTRACTS] Make TestToken support permit #1664)
  • Foundry installation instructions are overcomplicated because of previous foundry issue
  • SuperToken contract does not expose _underlyingDecimals and _toUnderlyingAmount, should be exposed with a getter function for _underlyingDecimals and an external toUnderlyingAmount function ([ETHEREUM-CONTRACTS] expose Supertoken underlying information #1663)
  • SuperTokenV1Library functions must use vm.startPrank instead of vm.prank: we know this internally, but this should be mentioned to end-user devs (added this to the docs)
@0xdavinchee 0xdavinchee added the Tag: TechDebt Technical debt that needs to be addressed label Sep 5, 2023
@hellwolf
Copy link
Contributor

hellwolf commented Sep 5, 2023 •
edited
Loading

Having to use a super app for call app action

can repoen this: #1038

Not supporting permit in our TestToken

Can reopen this: https://github.com/superfluid-finance/protocol-monorepo/issues

Foundry installation instructions are overcomplicated (you can specify the tag version instead of getting the commit hash)

I guess foundry fixed this in the upstream.

@0xdavinchee 0xdavinchee added the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Sep 12, 2023
@0xdavinchee
Copy link
Contributor Author

closing now as all of the points which can be addressed has been addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tag: TechDebt Technical debt that needs to be addressed Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hellwolf @0xdavinchee