New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect nonce check for google - sign in with id token #1829

Open

Lxstr opened this issue Nov 3, 2024 · 0 comments

Labels

bug

Lxstr commented Nov 3, 2024

Bug report

[ x] I confirm this is a bug with Supabase, not with my own application.
[ x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

IdToken returned by google does not contain a hashed nonce but currently, gotrue hashes the nonce in the request and checks if it matches the nonce in the id token payload.

Therefore it is impossible to get a successful nonce check. This have been confirmed against google package which returns a success nonce check:

https://google-auth.readthedocs.io/en/master/reference/google.oauth2.id_token.html

This has also been previously mentioned here #412

Lxstr added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment