Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more plugins to reduce config downstream #208

Open
nabobalis opened this issue Aug 9, 2023 · 3 comments
Open

Add more plugins to reduce config downstream #208

nabobalis opened this issue Aug 9, 2023 · 3 comments
Milestone

Comments

@nabobalis
Copy link
Contributor

Describe the feature

We currently have to add a lot of repeat extensions and config per package:

Examples:

notfound.extension
hoverxref.extension
sphinx_copybutton
sphinx_design
sphinxext.opengraph
sphinx_changelog

Proposed solution

Add these as dependencies to the theme and configure them once here so we do not have to repeat it downstre.

@nabobalis nabobalis added this to the v2.0.0 milestone Aug 9, 2023
@Cadair
Copy link
Member

Cadair commented Aug 9, 2023

I am unconvinced that hoverxref is something we want to do globally, but maybe we can just exclude the website and have it everywhere else?

Also I think sphinx-changelog kinda has to be specific to the individual projects? Not all of them use towncrier?

@nabobalis
Copy link
Contributor Author

I am unconvinced that hoverxref is something we want to do globally, but maybe we can just exclude the website and have it everywhere else?

Makes sense

Also I think sphinx-changelog kinda has to be specific to the individual projects? Not all of them use towncrier?

Do not want all our packages to use the same changelog system?

@Cadair
Copy link
Member

Cadair commented Aug 9, 2023

Do not want all our packages to use the same changelog system?

maybe 🤷

Either way, I slightly lean towards putting extensions and stuff in a shared config which don't require package specific use or config to work.

@Cadair Cadair modified the milestones: v2.0.0, v2.1.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants