Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the coalignment module #83

Open
wtbarnes opened this issue Mar 24, 2022 · 2 comments · May be fixed by #207
Open

Refactor the coalignment module #83

wtbarnes opened this issue Mar 24, 2022 · 2 comments · May be fixed by #207
Labels
coalignment Discussion An issue opened for, or undergoing discussion. Effort High Requires a large time investment. Package Intermediate Requires some of knowledge of the package. Priority Medium Non-urgent action required.

Comments

@wtbarnes
Copy link
Member

wtbarnes commented Mar 24, 2022 •
edited
Loading

The coalignment module now includes code from sunpy.image.coalignment as well as sunpy.physics.solar_rotation. Both of these bits of code provide methods for co-aligning images, but the API is a bit all over the place at the moment. We need to decide how we want users to interact with this code (e.g. do we want one mapsequence_coalign function with different keywords to select how the coalignment is done?) and refactor things to remove duplicate code.

We should also think about how we want to then incorporate new coalignment functions (e.g. #82).

This should probably be worked out prior to #79
@wtbarnes wtbarnes added Effort High Requires a large time investment. Package Intermediate Requires some of knowledge of the package. Priority Medium Non-urgent action required. coalignment Discussion An issue opened for, or undergoing discussion. labels Mar 24, 2022
@dstansby dstansby mentioned this issue Sep 19, 2022
Merged
@Abinash-bit
Copy link
Contributor

Is this issue still open?

@nabobalis
Copy link
Contributor

Yes, but there is an open PR that will close this issue.

@nabobalis nabobalis linked a pull request Nov 13, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coalignment Discussion An issue opened for, or undergoing discussion. Effort High Requires a large time investment. Package Intermediate Requires some of knowledge of the package. Priority Medium Non-urgent action required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New Coalignment API Deus1704/sunkit-image
3 participants
@nabobalis @wtbarnes @Abinash-bit